Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of
 module_init
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Vitaly Chikunov <vt@altlinux.org>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201015110241.89676-1-tianjia.zhang@linux.alibaba.com>
 <20201015120504.GA12976@gondor.apana.org.au>
 <f6d98764-dde8-6f40-c0e7-9eb5b087d713@linux.alibaba.com>
 <20201130022422.GA21049@gondor.apana.org.au>
From:   Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-ID: <df22e694-0a2e-811a-412e-269303c5d27d@linux.alibaba.com>
Date:   Mon, 30 Nov 2020 14:54:23 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201130022422.GA21049@gondor.apana.org.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/30/20 10:24 AM, Herbert Xu wrote:
> On Mon, Nov 30, 2020 at 10:21:56AM +0800, Tianjia Zhang wrote:
>>
>>> That is true only if there are non-generic implementations of
>>> the algorithms, which is not the case here.  Please explain the
>>> real reason why this is needed.
>>
>> This is a generic algorithm, the author Vitaly Chikunov has also confirmed
>> it, please consider this patch again.
> 
> As I said, the generic algorithm only needs to be loaded early *if*
> there are non-generic implementations.
> 
> Cheers,
> 

For ecrdsa, there is no reason to advance the initialization to 
subsys_init, this is just to make code clean up to have algorithm 
initialization uniform with other implementations.

It’s just that I think that in the commit c4741b230597 ("crypto: run 
initcalls for generic implementations earlier"), the modification to 
ecrdsa happened to be omitted, because from the point of commit time, it 
was submitted at the same time as the ecrdsa commits, and it may happen 
to be omitted for ecrdsa.

Best regards,
Tianjia