Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Biwen Li <biwen.li@nxp.com>
To:     Marc Zyngier <maz@kernel.org>,
        "Biwen Li (OSS)" <biwen.li@oss.nxp.com>
CC:     "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        Leo Li <leoyang.li@nxp.com>, "Z.q. Hou" <zhiqiang.hou@nxp.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiafei Pan <jiafei.pan@nxp.com>,
        Xiaobo Xie <xiaobo.xie@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [v3 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A
 external interrupt
Thread-Topic: [EXT] Re: [v3 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A
 external interrupt
Thread-Index: AQHWxsgYpP6sSSK1iEmWgP/gNfOyMqngVbYAgAAAcXA=
Date:   Mon, 30 Nov 2020 08:24:17 +0000
Message-ID: <DB6PR0401MB2438A99130A339416F2BC9038FF50@DB6PR0401MB2438.eurprd04.prod.outlook.com>
References: <20201130033055.38462-1-biwen.li@oss.nxp.com>
 <1271261ba2ad021041e0ba331c96a2d7@kernel.org>
In-Reply-To: <1271261ba2ad021041e0ba331c96a2d7@kernel.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 688ec9a3-8e54-4856-611a-08d895095466
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2020 08:24:17.3706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Hmj1rd7m7zwpdxoR/LkvKTIuNcr4ZQKArSRc7q3dAQDU5CjcQ/WJp4Ne7g+KGxZiTSEab6SfZgoZVHBqZMOu3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4444
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> On 2020-11-30 03:30, Biwen Li wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > Add an new IRQ chip declaration for LS1043A and LS1088A
> > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A.
> > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> > Change in v3:
> >       - cleanup code
> >       - remove robust copyright
> >
> > Change in v2:
> >       - add despcription of bit reverse
> >       - update copyright
> >
> >  drivers/irqchip/irq-ls-extirq.c | 17 +++++++----------
> >  1 file changed, 7 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-ls-extirq.c
> > b/drivers/irqchip/irq-ls-extirq.c index 4d1179fed77c..47804ce78b21
> > 100644
> > --- a/drivers/irqchip/irq-ls-extirq.c
> > +++ b/drivers/irqchip/irq-ls-extirq.c
> > @@ -18,7 +18,7 @@
> >  struct ls_extirq_data {
> >       struct regmap           *syscon;
> >       u32                     intpcr;
> > -     bool                    bit_reverse;
> > +     bool                    is_ls1021a_or_ls1043a;
> >       u32                     nirq;
> >       struct irq_fwspec       map[MAXIRQ];
> >  };
> > @@ -30,7 +30,7 @@ ls_extirq_set_type(struct irq_data *data, unsigned
> > int type)
> >       irq_hw_number_t hwirq =3D data->hwirq;
> >       u32 value, mask;
> >
> > -     if (priv->bit_reverse)
> > +     if (priv->is_ls1021a_or_ls1043a)
> >               mask =3D 1U << (31 - hwirq);
> >       else
> >               mask =3D 1U << hwirq;
> > @@ -174,14 +174,9 @@ ls_extirq_of_init(struct device_node *node,
> > struct device_node *parent)
> >       if (ret)
> >               goto out;
> >
> > -     if (of_device_is_compatible(node, "fsl,ls1021a-extirq")) {
> > -             u32 revcr;
> > -
> > -             ret =3D regmap_read(priv->syscon, LS1021A_SCFGREVCR,
> &revcr);
> > -             if (ret)
> > -                     goto out;
> > -             priv->bit_reverse =3D (revcr !=3D 0);
> > -     }
>=20
> This isn't explained in the commit message. You are changing the way you =
infer
> some properties, and that's not innocent. Please describe all important c=
hanges
> in the commit message.
Sure, will update commit message for this.
>=20
> > +     if (of_device_is_compatible(node, "fsl,ls1021a-extirq") || \
>=20
> Spurious trailing \?
Don't need it, will remove it in v4.
>=20
> > +         of_device_is_compatible(node, "fsl,ls1043a-extirq"))
> > +             priv->is_ls1021a_or_ls1043a =3D true;
>=20
> Which is better written as:
>=20
>          priv->is_ls1021a_or_ls1043a =3D (of_device_is_compatible(node,
> "fsl,ls1021a-extirq") ||
>=20
> of_device_is_compatible(node, "fsl,ls1043a-extirq"));
Sure, np. Will update it in v4.
> >
> >       domain =3D irq_domain_add_hierarchy(parent_domain, 0, priv->nirq,
> node,
> >                                         &extirq_domain_ops, priv);
> @@
> > -195,3 +190,5 @@ ls_extirq_of_init(struct device_node *node, struct
> > device_node *parent)  }
> >
> >  IRQCHIP_DECLARE(ls1021a_extirq, "fsl,ls1021a-extirq",
> > ls_extirq_of_init);
> > +IRQCHIP_DECLARE(ls1043a_extirq, "fsl,ls1043a-extirq",
> > ls_extirq_of_init);
> > +IRQCHIP_DECLARE(ls1088a_extirq, "fsl,ls1088a-extirq",
> > ls_extirq_of_init);
>=20
> Thanks,
>=20
>          M.
> --
> Jazz is not dead. It just smells funny...