Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3348337pxu; Mon, 30 Nov 2020 00:30:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTeDikzJGbI/7bsAA6KZIXbJyfOhOjx88ff9p2lsdKuOi9Ucn5fGkeRlAIq3EwKt8Hn9DR X-Received: by 2002:a17:906:507:: with SMTP id j7mr9045841eja.245.1606725059510; Mon, 30 Nov 2020 00:30:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606725059; cv=none; d=google.com; s=arc-20160816; b=uPyTbngMtYsASUbwQ8y0iyOh+F2otKnbtiZx10pFFSddT9+CVp69nghSvucZjeTa0O 37F555EtrBVCOCFSffkB5VQGlZTAQbPXeU48n3gy6UXg4iEJtkujQe+SCuLRnhk6kGSR 9Du/lZGDHiYmGBCqUd/Jqz8A0eX/qKOQCXfsqb/RMgJuS4RxwLRCDzFvlAcfrO4QoeCs 1TFwjfiRi4XGfd09jJiYt5OUB0v5eMzST1u60A8h1HfN6Xr/9JDkxyjJG1FRWtbkPw3E ZDFdbGUS5XOBdGc7GhVfXOk+vBhFQ5MCXPat8Eat9zVvk8zSNC/Y8bYsYUyhRIMserUW g2mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=//iOwas72DO3T9VkHzfJu7elnq/LOHLMsMJU6rLkq+s=; b=jABsDay7QgzLR1O+1DaHAoig7kSttUZ/+Mqqwn+cg595pC+A2xyrv6Mpmzp0yd7REU a+b8ycNVM2Rr07gEw0WUsiqRxB+Qu+JtPABqIzO8CmGjhYSLoNtaBKYXanOrenwDf1/g sREdgZZPjfkU3qYhqjKUo1LIzgHz161MRyzAqlCBLOES1OhrOtUg2vj2M1ZkstjuBClL UmtthvNCYOgdixLFe/cY9Kq/bgRDYKeANGrH/auarXDnJdGpL0vXVeyPT2V4KcyNjB8M xRJwNnMCVcsLBkyMBOnPTt/8uXJeCe879XO3AjPnMooRNn1MGSP+6eTHLQNvnVvg4I40 BmBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si10009502ejt.331.2020.11.30.00.30.36; Mon, 30 Nov 2020 00:30:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgK3I3L (ORCPT + 99 others); Mon, 30 Nov 2020 03:29:11 -0500 Received: from verein.lst.de ([213.95.11.211]:43356 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgK3I3K (ORCPT ); Mon, 30 Nov 2020 03:29:10 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 32F3768B02; Mon, 30 Nov 2020 09:28:27 +0100 (CET) Date: Mon, 30 Nov 2020 09:28:26 +0100 From: Christoph Hellwig To: Ricardo Ribalda Cc: Christoph Hellwig , Mauro Carvalho Chehab , Marek Szyprowski , IOMMU DRIVERS , Joerg Roedel , Robin Murphy , Linux Doc Mailing List , Linux Kernel Mailing List , Linux Media Mailing List , Tomasz Figa , Sergey Senozhatsky Subject: Re: [PATCH 3/6] dma-iommu: remove __iommu_dma_mmap Message-ID: <20201130082826.GB32234@lst.de> References: <20201124153845.132207-1-ribalda@chromium.org> <20201124153845.132207-3-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124153845.132207-3-ribalda@chromium.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 04:38:42PM +0100, Ricardo Ribalda wrote: > From: Christoph Hellwig > > The function has a single caller, so open code it there and take > advantage of the precalculated page count variable. > > Signed-off-by: Christoph Hellwig It turns out this isn't really required for the series. I think it is a useful cleanup, but it should probably be picked up separately. Robin, any comments?