Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3349782pxu; Mon, 30 Nov 2020 00:33:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMi5yng18Ki/5nkr/Yb6h/J9XBQNVZt4s4xxo3RyqUaPMEVqAYGnWuBtEDqkTbv/YNQMHa X-Received: by 2002:a17:906:16da:: with SMTP id t26mr19235153ejd.478.1606725228479; Mon, 30 Nov 2020 00:33:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606725228; cv=none; d=google.com; s=arc-20160816; b=Zz8pVVKHpAe1VHXSFaxOskh4BxLv3iI/uJ3lkj5rHpj4jXrZPNsdgn6e5qjTxhLqJF oWYAomcA84Mp9CWRzq7aRjhz9HFL/g0qjLk3YFKv5UbruHlu10cIeh+hkhgs60c1ts1k B33CBCnCwTTi2t5T64Vkzh3sOn6zNaGFVaviqp7d+u587uUJOVZJiCxaZLvWG1mNoQvT UBC7UizqYM9JcQyS7JAfWoqQtDqFz6TENjsplf5FD9d3Lo13mr3Q99yfD5utqD77KDzS 7iVWtYc2uUhzf0Mwf5LWMMCXpHZOldM1yYzueZ4uZ7z5H9KKYDFRHq4nwckbxaHsU8Cd epZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dlMIUuk5t9/HdJR9i9suY7in0Y/IA8FpeIUXUx4PpM0=; b=Rq7LhdE0/HfzgJejTPQT3TEXAl1gbx735sPB0D8bZNHjVMtO+XRgelDHOTf6LeZJ7Q kQ4IwCjNWr98bqmU78sN7/5Anmy8gJAKz5EaLPqa/WL4RoRHsgFmStSuODxdq21Q7roB hVT4kA+8UN4oRTHbPdLHwEjfkI8dLnFTRSuNi7x3C6clKeEuGiYWHJOJKUPHwJz4z1Q0 6o6be1e5ykbcclDFi/I4YROcLAGi6SCvLYVtKZtY2t3aHGM/4XfYSr+yA1z2OeHG0cLk 4Mwvkh23YmYlMLzvKL7FKPuOyqofnyjQTYP1G3EjvMf2z2WEu1vexJi/47trAcHKRW2L QteQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vUaYt+r8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf13si8316558ejb.317.2020.11.30.00.33.26; Mon, 30 Nov 2020 00:33:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vUaYt+r8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbgK3IbB (ORCPT + 99 others); Mon, 30 Nov 2020 03:31:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgK3IbB (ORCPT ); Mon, 30 Nov 2020 03:31:01 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C826CC0613CF for ; Mon, 30 Nov 2020 00:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dlMIUuk5t9/HdJR9i9suY7in0Y/IA8FpeIUXUx4PpM0=; b=vUaYt+r8+5w20rf9SjYeqKN1AH qohY38w7m3qq76ehoimsy2DMTIcug4MWY3Q3ntLAYH9v0rmwLIVZK2kZEHrEcF6rOhvNrj5gd+93D YrsgO8punGkfvok3EZUBJqSK7/qr8Sbh3yniklPO4T4Yo+eee8jouNzbiXQBjlW07WdEsM7PvBTFj Yk7kSKkI/Wj1mJkhdOZZONHarMDxfrYe+nrE8OLuS2wHs5pnmjL2SR6VuzinFR8AyVfRq48cEiwHJ ITcQSRWzlOFfbcviQ92SIJ7NPmgotwLX4eER8NQC6iFNEwZTO/1d1yzapVYOye7Xo/ZTc4IFljsCY QGQGEeVg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjeZb-0003xv-SA; Mon, 30 Nov 2020 08:30:15 +0000 Date: Mon, 30 Nov 2020 08:30:15 +0000 From: Christoph Hellwig To: Eric Lin Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, walken@google.com, daniel.m.jordan@oracle.com, peterx@redhat.com, akpm@linux-foundation.org, penberg@kernel.org, aou@eecs.berkeley.edu, palmer@dabbelt.com, paul.walmsley@sifive.com, dslin1010@gmail.com, Alan Kao Subject: Re: [PATCH] riscv/mm: Prevent kernel module access user-space memory without uaccess routines Message-ID: <20201130083015.GA14676@infradead.org> References: <20201130053037.27006-1-tesheng@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130053037.27006-1-tesheng@andestech.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!user_mode(regs) && addr < TASK_SIZE && unlikely(!(regs->status & SR_SUM))) Please avoid the overly long line.