Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net: flow_offload: remove trailing semicolon in macro
 definition
To:     trix@redhat.com, davem@davemloft.net, kuba@kernel.org,
        wenxu@ucloud.cn, pablo@netfilter.org, jiri@mellanox.com,
        herbert@gondor.apana.org.au, paulb@mellanox.com,
        john.hurley@netronome.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201127193727.2875003-1-trix@redhat.com>
From:   Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <9d9536d9-b2ba-d3f9-5cf7-56c8dd67bb3e@gmail.com>
Date:   Mon, 30 Nov 2020 09:24:03 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201127193727.2875003-1-trix@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/11/2020 19:37, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  net/core/flow_offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c
> index d4474c812b64..59ddfd3f3876 100644
> --- a/net/core/flow_offload.c
> +++ b/net/core/flow_offload.c
> @@ -32,7 +32,7 @@ EXPORT_SYMBOL(flow_rule_alloc);
>  	struct flow_dissector *__d = (__m)->dissector;				\
>  										\
>  	(__out)->key = skb_flow_dissector_target(__d, __type, (__m)->key);	\
> -	(__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask);	\
> +	(__out)->mask = skb_flow_dissector_target(__d, __type, (__m)->mask)	\
>  Strictly speaking shouldn't this macro have a do {} while (0)
 around it anyway?

-ed