Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 10:34:04 +0100
From:   Daniel Wagner <dwagner@suse.de>
To:     Maciej =?utf-8?Q?=C5=BBenczykowski?= <zenczykowski@gmail.com>
Cc:     trix@redhat.com, njavali@marvell.com, jejb@linux.ibm.com,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition
Message-ID: <20201130093404.xjow7bddb5jw3myj@beryllium.lan>
References: <20201127182741.2801597-1-trix@redhat.com>
 <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan>
 <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com>
Precedence: bulk

On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@suse.de> wrote:
> > >  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)             \
> > > -     atomic_dec(&__qpair->ref_count);                \
> > > +     atomic_dec(&__qpair->ref_count)         \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
> 
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.

Right! Didn't realize it. The backslash should be removed.