Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 09:55:12 +0000
From:   Will Deacon <will@kernel.org>
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     Wei Li <liwei391@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Ionela Voinescu <ionela.voinescu@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Amit Daniel Kachhap <amit.kachhap@arm.com>,
        Vladimir Murzin <vladimir.murzin@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        guohanjun@huawei.com
Subject: Re: [PATCH v3] drivers/perf: Add support for ARMv8.3-SPE
Message-ID: <20201130095512.GA24098@willie-the-truck>
References: <20201127060322.29025-1-liwei391@huawei.com>
 <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <861cf678-3e6f-7627-8d41-b9395cb6e5e0@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Nov 27, 2020 at 12:03:35PM +0000, Suzuki K Poulose wrote:
> On 11/27/20 6:03 AM, Wei Li wrote:
> > Armv8.3 extends the SPE by adding:
> > - Alignment field in the Events packet, and filtering on this event
> >    using PMSEVFR_EL1.
> > - Support for the Scalable Vector Extension (SVE).
> > 
> > The main additions for SVE are:
> > - Recording the vector length for SVE operations in the Operation Type
> >    packet. It is not possible to filter on vector length.
> > - Incomplete predicate and empty predicate fields in the Events packet,
> >    and filtering on these events using PMSEVFR_EL1.
> > 
> > Update the check of pmsevfr for empty/partial predicated SVE and
> > alignment event in SPE driver. For adaption by the version of SPE,
> > expose 'pmsver' as cap attribute to userspace.
> > 
> > Signed-off-by: Wei Li <liwei391@huawei.com>
> 
> nit: Do we need to update the Kconfig help text too ? Right now that says :
> 
> --
> 
> 
> tristate "Enable support for the ARMv8.2 Statistical Profiling Extension""
> ....
> 
> help
>   Enable perf support for the ARMv8.2 Statistical Profiling
>   Extension, which provides periodic sampling of operations in

I think it's ok as-is, to be honest. It identifies the version of the
architecture when the feature was introduced, and I think it's only
reasonable to assume that subsequent versions of the architecture might
add extensions.

Will