Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3400190pxu; Mon, 30 Nov 2020 02:09:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGpyNEb5buCV2LEDLm/VFSqvJzK+98QJhFn/hv1skJnq6J7e9I090OBF53Zn73AUS+KVyO X-Received: by 2002:a17:906:2932:: with SMTP id v18mr19715260ejd.144.1606730984304; Mon, 30 Nov 2020 02:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606730984; cv=none; d=google.com; s=arc-20160816; b=g9cNp1JbdbsMuj07DT7eYyMzzKMICWgVzy0qU8ZDW93dZHM4SbBRX1NWoANBqFAH/G n2QgTpKdAOKjNvfhcCBxLm93ZhEhDkgHMrMi+i8toXLJBgmihN+ygw/4vLE0K2+s7T/2 uEmFB9AqLAGlfxcK5xe+L6PLAoweGtuhi8UcjJRhmfGanBu17Sy2if8xuw43ujEtu7+n NNfJFiPAVI9G6WLac4IiuzI0RdgN1Mt3Yf5n50kuT0nrbz7Siu5zsT3wLN9RH/l6J41A sFqkFXWtvwFB/P2IqfNuuCVCKry5J3uEObUBRdmHKcR8RhnRcBxnFODCGHvO/vcxhrnv HvrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=2HTRFOjw+TomkdVoKhsPrdh28bt5QNRrLXAeIOSfBdY=; b=DD7hOvrEWtV+U+IFfQnLKPYTbiUPeNIVDNz7hmZPpgQVRIh6Slfg68Z/gxTP2UGTlb jR2Fs/ID8dVcNE5M1/q4TUGqeasoB4ZkMtK7MWv5kro+JS/LOagdq0Rth/mHfUJQwxL9 mApgwBWCdzD+EJBAMNcy93tKthko6npzoHTCcKzL7jAZgzWB6BR8XdSic/qr/zG+sjuz /1LBm7leC6WvjyJXRVsHHTl81QyRc6iE7sDp3kBlWj3WzIdszVqJCPADRfkbg0khKr6J Qd8Y2hmFuAXx4YjQ2VgfX8gdXDryNWZEENOeulEVR8siaruANbOHugdksBMK6Ku08TPF aSNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GYYUTumL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si10838067edl.367.2020.11.30.02.09.21; Mon, 30 Nov 2020 02:09:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GYYUTumL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbgK3KFu (ORCPT + 99 others); Mon, 30 Nov 2020 05:05:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35969 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgK3KFt (ORCPT ); Mon, 30 Nov 2020 05:05:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606730663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2HTRFOjw+TomkdVoKhsPrdh28bt5QNRrLXAeIOSfBdY=; b=GYYUTumLplVNmG4MYvwAsua3cLbAbHSLx8DRz0+XP60paCyU6JcMAxQT0AdeyOnhdytK7L 8mHTYZ8A6Wri2M8C01HIxS1UvY4etIxj0UuIsrr4T0zRFv2YsTM62l3gnMv2BBiPstFHPz dWVlZQj7VZTxNPXi9s6GQ0kqA4qQ1oE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-ZeSccZCNPKqUNquGz1m8ow-1; Mon, 30 Nov 2020 05:04:21 -0500 X-MC-Unique: ZeSccZCNPKqUNquGz1m8ow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BC7F1009466; Mon, 30 Nov 2020 10:04:20 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-159.rdu2.redhat.com [10.10.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5195C5D9D2; Mon, 30 Nov 2020 10:04:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1604673513-29088-1-git-send-email-alex.shi@linux.alibaba.com> References: <1604673513-29088-1-git-send-email-alex.shi@linux.alibaba.com> To: Alex Shi Cc: dhowells@redhat.com, David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] certs/blacklist: fix kernel doc interface issue MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3096974.1606730658.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 30 Nov 2020 10:04:18 +0000 Message-ID: <3096975.1606730658@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex Shi wrote: > /** > * mark_hash_blacklisted - Add a hash to the system blacklist > - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa42= 9783") > + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa4= 29783") You should remove the dash when making this change. I'll do that for you. David