Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lTl7Uu+9OB1motRnm87W/Ps42boK3+pP3zSCpD7CS9LG4lA8GyMZG2mhTp6bSCaevMpS/3oVS4
 YnGfjYrLEKFw==
IronPort-SDR: s6bBcD5XXuH8CcyHYxPeLfKyKFHJqkNDMGls2aIuhl6c18vpFzFDk+kn6McJ5BVaLyD9uUBAmc
 c0ZP197bSHhQ==
Date:   Mon, 30 Nov 2020 13:22:50 +0200
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
To:     Luo Jiaxing <luojiaxing@huawei.com>
Cc:     bgolaszewski@baylibre.com, linus.walleij@linaro.org,
        Sergey.Semin@baikalelectronics.ru, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v1] gpio: dwapb: mask/unmask IRQ when disable/enable it
Message-ID: <20201130112250.GK4077@smile.fi.intel.com>
References: <1606728979-44259-1-git-send-email-luojiaxing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1606728979-44259-1-git-send-email-luojiaxing@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Nov 30, 2020 at 05:36:19PM +0800, Luo Jiaxing wrote:
> The mask and unmask registers are not configured in dwapb_irq_enable() and
> dwapb_irq_disable(). In the following situations, the IRQ will be masked by
> default after the IRQ is enabled:
> 
> mask IRQ -> disable IRQ -> enable IRQ
> 
> In this case, the IRQ status of GPIO controller is inconsistent with it's
> irq_data too. For example, in __irq_enable(), IRQD_IRQ_DISABLED and
> IRQD_IRQ_MASKED are both clear, but GPIO controller do not perform unmask.

Sounds a bit like a papering over the issue which is slightly different.
Can you elaborate more, why ->irq_mask() / ->irq_unmask() are not being called?

-- 
With Best Regards,
Andy Shevchenko