Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3460074pxu; Mon, 30 Nov 2020 03:47:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRk/tqD3lMQFKf84EZ3fZVOW1SAEkqxycUcoPwfh/I+OeHDBJYgV+sB/PCw0AblX2s2cDb X-Received: by 2002:a05:6402:19b4:: with SMTP id o20mr21082377edz.103.1606736853183; Mon, 30 Nov 2020 03:47:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606736853; cv=none; d=google.com; s=arc-20160816; b=dD1q4Z8Sb92NqqMbYP6EX0EYBhvBQDU09X72xI+6xhk0tIBWSA5cjle/HMLi03FHFh QWLza462D0Bo12HXT2WmnMbeDq+jbbrOcc7ECG41AvF6WkEbY+/pBtq6HkqCqM+RB0d2 ef2ZLE41jM994yBai29eBeUdSgMCaHcrdi3LjMCvkkA1W16ZiHKgh/O7xEq57KC1O51v R8s8fHyPX2b35i4SylbrgL/P9iISUluGWy3ZxPFQ96lCEcjt+bFfQaCOoSzqVcwvqyRU PMowiCedH9FtkcaK3FZmmMxgGsJRVo2Rrblm80FJB+8SaMUz8DwIoHd6ljb5B5mu1ttc M7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=RaHLzPE1eO6+iuatfZUUeCnsQ46TRXVJpL+R26wfEdY=; b=vpGPw0XVf/BULMF4Olb7BHrqqeFIR8PiqCp1VBYPV2cJDgNP+QlM2HObdIW92Hg6vf R8BhsSC4JBLCSc3z00+FfT1uwQwcy0PQBgZBVs1zVCyO8dU7zY+51JJxNvCGDsbHf4fo 2J4WccTQo6lCcM67Ovbkh6eR3aSdYKAliNODJ5cES/qXCHTgVNsl+yLXW9+YJH3Z7LGW P/SDfwYaO4z2Lik+q7gBzbah27Q35tGPpSsGvy1cm35c4Fmtykt3vCrfe3jzekhkUldT IPK4d/vkqPvWZl9dc5nqYo+tee+Hg5gInZ+IVkRPR1fMxEh69tmvUrVdal0A+IjeN/g6 7Mtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aKWrdF06; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si12377286edw.81.2020.11.30.03.47.09; Mon, 30 Nov 2020 03:47:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aKWrdF06; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbgK3LoZ (ORCPT + 99 others); Mon, 30 Nov 2020 06:44:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726385AbgK3LoZ (ORCPT ); Mon, 30 Nov 2020 06:44:25 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E65C4C0613D2; Mon, 30 Nov 2020 03:43:44 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id w202so10213202pff.10; Mon, 30 Nov 2020 03:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RaHLzPE1eO6+iuatfZUUeCnsQ46TRXVJpL+R26wfEdY=; b=aKWrdF06lEsEW2HA12ZYDwToDfjtKzwKfsn3xEgLdPads8DMM7oYf9sHu8LVKU+aJV WFhtGqFv5wFHbxci48TJttdclzt0eVTRIBoTC2JFhhJELUoQpX+i075xf21FPK0GfPcJ kEkfTh6zSq6bD/yAwtpte64nSM3ZBw2373RVn7GsZ9VAFGECSch00gOi3/XlcL1ywTC4 SI5QtPYG683+guJpxzR3J2RiWOQPgL+0hwYCZDkqC07BLV1mELepn5O0xwCzLsa3p2Gf YMx5ePOJFHa6mH2/QbrkFxSHFBBv7bsuKajvzJZkObyaifoVmJoOXjgyx10dsk4m6eY4 PPRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RaHLzPE1eO6+iuatfZUUeCnsQ46TRXVJpL+R26wfEdY=; b=rqMyM081I6tdJyXEB5y9eIHmvmZTTYWpZsWBz29oPlqkxAoSgLscjFIXNiPl6UjHUr t8QGPCkiGb4Dy5uRXTauF0sXVPz0KIMnivKM/4rre2e6+VRRUTnOmQh7NqDv/LvDruce RkF7YtnV1Bge5en761aAYtF52pe5dRPYm4wWyL+YsChTansAIOEfwktdH7ZRjOkZ0c+6 WFC7VmSdq90fD1YbzfAeRiEMtrMvAiYV852Xgkyq/AfnhxZ1ftsL5KQGHsTBxJ9fIsWw lzG5UoTraEY8y0vywcsiq6QoS1U1ZG3keHtzd91egItYG5t9/eIgjeLM8ocBpNhWf4mH ghYg== X-Gm-Message-State: AOAM533fGk4RRDogPYT6bUmv/MRDvewe8txyrdg7JibFvmP3i8LlOEGL aPNFd1wC4V2qC0Ky7GH9IhRegjYDL64nV4zPBgFONNStnB8= X-Received: by 2002:a63:ff10:: with SMTP id k16mr6761379pgi.4.1606736624502; Mon, 30 Nov 2020 03:43:44 -0800 (PST) MIME-Version: 1.0 References: <20201130110447.16891-1-frieder.schrempf@kontron.de> In-Reply-To: <20201130110447.16891-1-frieder.schrempf@kontron.de> From: Andy Shevchenko Date: Mon, 30 Nov 2020 13:44:33 +0200 Message-ID: Subject: Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional To: Schrempf Frieder Cc: Charles Gorand , =?UTF-8?Q?Cl=C3=A9ment_Perrochaud?= , "David S. Miller" , devicetree , Linux Kernel Mailing List , linux-nfc@lists.01.org, netdev , Stephan Gerhold Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder wrote: > > From: Frieder Schrempf > > There are other NXP NCI compatible NFC controllers such as the PN7150 > that use an integrated firmware and therefore do not have a GPIO to > select firmware downloading mode. To support these kind of chips, > let's make the firmware GPIO optional. ... > - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); > + if (phy->gpiod_fw) > + gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); This change is not needed. -- With Best Regards, Andy Shevchenko