Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3532071pxu; Mon, 30 Nov 2020 05:18:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxeG19Vrr4PUDGpJVAQdH3YrHRG1BlcUsmO1coWPMZmKN0crHviCpQiMfSlvfQ87JIAnQmm X-Received: by 2002:a17:906:ce3c:: with SMTP id sd28mr20443834ejb.485.1606742337941; Mon, 30 Nov 2020 05:18:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606742337; cv=none; d=google.com; s=arc-20160816; b=c+TRhCphoj1l6Edxaa+rw2JvB+l32zScCVTRthRIdg2TbSyV4b04SBdesQizfWcm9p R+mbxa4i/W6kKEY4bXSE4PHaKWmgciB9Tex/iFxqahCexvKc1RlLzYY86UjvPnPyWZXX E+wnzg8Tdpo3XPLgjfNsTHnEifInihBzs5XGCWLeE6+LJw6uz/b4GwK+qKRT/vfjbdMn Bn/guCty5Wwrs+xuCQzRgc0xUi8NkftV9TNkLsaYTk/TM0sI3yo2mY2nAT0LHivt7rKG 85ku+NE8JXtd4cM4VTWDG/ss1XD3kyG8xYqO3w6DwWO+UUQqQSnNeYYUM1YbNdxaYrkF XpKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=l3QMImLUzsUxdD3lrxokZ6OLsGo9+qiElCnfZdbpvzA=; b=VTlG/5zgMYmkUqub4qTfL9i3BvEOaa93E2nVikpQLkbwrY/kg9Xwd9gY7xul1kW7p2 HuUrr1XAeORD41ZZxVsKLkqEjNwzHqwquCqcIHT9z839DOoVawK8Mg2qdFKZveBwovSN 2Pp9USlMMkpZ7MEzQ5rK/xv8sxizRlMyuIEu5RSfre/h66TI1PKTdVxHpP2wxfR1Ft4a Ryvd7vAw3FvVQO/EFigHOsqjUz8Asb796v2Ij+l8AWttLLSEsZQ0SKtCg3fOst3X8FlQ Uk98hXhYPz/c1Vsc+ljHoBRxyPS16KPKDTCJlMI2MF7BZLZOEKmZ1I6OgTr0/ukf8qAy 1Tqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UECHBboa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gf18si2428417ejb.202.2020.11.30.05.18.33; Mon, 30 Nov 2020 05:18:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UECHBboa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbgK3NO4 (ORCPT + 99 others); Mon, 30 Nov 2020 08:14:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36191 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgK3NO4 (ORCPT ); Mon, 30 Nov 2020 08:14:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606742010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3QMImLUzsUxdD3lrxokZ6OLsGo9+qiElCnfZdbpvzA=; b=UECHBboa2pJ07GYWLO2EQfvVgESjKBetXPTXMhUNV1i9qB4Ss6da9ZfrBpcta1bxcR6BMH ShUcrJf77c6T237uFzYKqsndydiFpwW1i/KSbBn367tuMoruiDZ4+HHAei0V4CZDlDtiy7 86zygyDa/LWtJRh7unfMCCdEb4j0LWQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-DQxZP_vYMRilDJNHNa_ZRg-1; Mon, 30 Nov 2020 08:13:28 -0500 X-MC-Unique: DQxZP_vYMRilDJNHNa_ZRg-1 Received: by mail-wm1-f72.google.com with SMTP id k128so7415437wme.7 for ; Mon, 30 Nov 2020 05:13:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3QMImLUzsUxdD3lrxokZ6OLsGo9+qiElCnfZdbpvzA=; b=B0h9jnzCR63hfrUa9rfz2FqVI0w2XeNZVR8ALFNxfxkOCANl46iEm2kzBGU5YO+kYq xkxE4JGmEK7JXJcXcKPX+4kOTmjljWPCxRMoj3OO/uLLZyl4sFuZaoFKuQTXPvBP64eR ikosa4o6XooOg+JcgUdrfM+ZLQYrCBGafXWlDkaBxc1S1s1AKbWcaTWl5cLSXJi5wRhr 5Bnxwng1Dq1xy6U/kBb3BGCWXkrlw6qi8Ty/iB/Up5tMipJ+ZtebsASiMVWrw/H5+0Iu cuRXfebyZicwI293kI1YQ7Up4tAma0JCNf+yXIUKQnG1lmFys7vZOYnnJ7cVZ5cQywpC MQTw== X-Gm-Message-State: AOAM532jkW6Ao6kxk1sW1BFYOCyzIl6KdQ7tiAUwn3tJ8l0j+0XuCl4A EG1pv0gm4rGDidZmsDzOgkGB3j9HmX0xJCa256s23/CJN3hpPBMyLNnOGncdueXquOlOotYpgk7 rQFSzimwKvrxrLvzNQaVM1pxO0scOjSBSjGx//Yic X-Received: by 2002:a5d:6250:: with SMTP id m16mr29212889wrv.400.1606742006900; Mon, 30 Nov 2020 05:13:26 -0800 (PST) X-Received: by 2002:a5d:6250:: with SMTP id m16mr29212862wrv.400.1606742006654; Mon, 30 Nov 2020 05:13:26 -0800 (PST) MIME-Version: 1.0 References: <20201130014404.36904-1-sergey.senozhatsky@gmail.com> <5b015b83-f183-526a-94e7-029f4c98b30b@infradead.org> In-Reply-To: From: Andreas Gruenbacher Date: Mon, 30 Nov 2020 14:13:15 +0100 Message-ID: Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build To: Sergey Senozhatsky Cc: Randy Dunlap , Christoph Hellwig , "Gustavo A. R. Silva" , Namjae Jeon , LKML , Al Viro , Jan Kara Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 2:09 PM Andreas Gruenbacher wrote: > Note that ext2 / ext4 could be built without POSIX ACL support in the > past. That's at least broken since the following two commits though: > > commit 59fed3bf8a461 ("ext2: cache NULL when both default_acl and > acl are NULL") > commit 6fd941784b8ac ("ext4: cache NULL when both default_acl and > acl are NULL") Scratch that, this is in fs/ext[24]/acl.c which is only included when CONFIG_FS_POSIX_ACL is defined. Thanks, Andreas