Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 22:28:03 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To:     Andreas Gruenbacher <agruenba@redhat.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Christoph Hellwig <hch@lst.de>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Namjae Jeon <linkinjeon@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on
 non-posix-acl build
Message-ID: <X8TzY0rotaSZ2FYv@jagdpanzerIV.localdomain>
References: <20201130014404.36904-1-sergey.senozhatsky@gmail.com>
 <5b015b83-f183-526a-94e7-029f4c98b30b@infradead.org>
 <X8Rj0s/Emv9Qmv3d@jagdpanzerIV.localdomain>
 <X8RkVIxou1D1YfEb@jagdpanzerIV.localdomain>
 <X8RpFo+5m1i4L5Gn@jagdpanzerIV.localdomain>
 <c96f60f4-f525-2957-6a8a-ae9e3288b04a@infradead.org>
 <CAHc6FU59uNEq4Xz8W7boG6y3+u3F1tz93RKSW+odM38rx37_9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHc6FU59uNEq4Xz8W7boG6y3+u3F1tz93RKSW+odM38rx37_9A@mail.gmail.com>
Precedence: bulk

Hi,

On (20/11/30 14:09), Andreas Gruenbacher wrote:
> 
> Sergey, what actual problem is your patch trying to solve? It sounds
> like this is either theoretical and pointless, or you're trying to
> build an external module that uses POSIX ACL functions that shouldn't
> be needed when CONFIG_FS_POSIX_ACL is disabled.

It's an external module, that OpenWRT folks build with !FS_POSIX_ACL.
It compiles just fine, but modprobe fails because there are several
exported ACL symbols that don't provide dummy definitions (which the
module in question didn't guard with ifdef-s).

> In the latter case, the external module will just end up including dead
> code, so the module should be fixed instead.

ifdef-s work. But since posix_acl.h already provides some dummy
definitions for exported symbols, I thought that that list can
be extended (become complete).

	-ss