Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 15:32:41 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Jialin Zhang <zhangjialin11@huawei.com>
Cc:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alan Cox <alan@linux.intel.com>,
        Dave Airlie <airlied@redhat.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        huawei.libin@huawei.com
Subject: Re: [PATCH] drm/gma500: Fix error return code in psb_driver_load()
Message-ID: <20201130143241.GO401619@phenom.ffwll.local>
Mail-Followup-To: Jialin Zhang <zhangjialin11@huawei.com>,
        Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        David Airlie <airlied@linux.ie>, Alan Cox <alan@linux.intel.com>,
        Dave Airlie <airlied@redhat.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, huawei.libin@huawei.com
References: <20201130020216.1906141-1-zhangjialin11@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201130020216.1906141-1-zhangjialin11@huawei.com>
Precedence: bulk

On Mon, Nov 30, 2020 at 10:02:16AM +0800, Jialin Zhang wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jialin Zhang <zhangjialin11@huawei.com>

Out of curiosity, what is hulk robot matching here? This is a really
interesting bug for automated checkers to find!

Thanks for the patch, applied to drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/gma500/psb_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
> index 34b4aae9a15e..074f403d7ca0 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.c
> +++ b/drivers/gpu/drm/gma500/psb_drv.c
> @@ -313,6 +313,8 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
>  	if (ret)
>  		goto out_err;
>  
> +	ret = -ENOMEM;
> +
>  	dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
>  	if (!dev_priv->mmu)
>  		goto out_err;
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch