Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition
To:     Daniel Wagner <dwagner@suse.de>
Cc:     njavali@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, GR-QLogic-Storage-Upstream@marvell.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201127182741.2801597-1-trix@redhat.com>
 <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan>
From:   Tom Rix <trix@redhat.com>
Message-ID: <3baa674f-ce34-34a9-26ec-1d3e0e2ebdcd@redhat.com>
Date:   Mon, 30 Nov 2020 08:16:59 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 11/30/20 1:17 AM, Daniel Wagner wrote:
> Hi Tom,
>
> On Fri, Nov 27, 2020 at 10:27:41AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
>
>> ---
>>  drivers/scsi/qla2xxx/qla_def.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>> index ed9b10f8537d..86d249551b2d 100644
>> --- a/drivers/scsi/qla2xxx/qla_def.h
>> +++ b/drivers/scsi/qla2xxx/qla_def.h
>> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>>  } while (0)
>>  
>>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
>> -	atomic_dec(&__qpair->ref_count);		\
>> +	atomic_dec(&__qpair->ref_count)		\
> Nitpick, please insert an additional tab after the remove so that the
> backlashes align again.

How about removing the last escaped newline and the next empty line ?

Tom

>
> Thanks,
> Daniel
>