Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: defconfig: Enable QCOM_SCM as builtin
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Vinod Koul <vkoul@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Olof Johansson <olof@lixom.net>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, John Stultz <john.stultz@linaro.org>
References: <20201118162528.454729-1-bjorn.andersson@linaro.org>
From:   Steev Klimaszewski <steev@kali.org>
Message-ID: <444557fe-32f5-9e1a-8165-c9c952619516@kali.org>
Date:   Mon, 30 Nov 2020 10:30:17 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201118162528.454729-1-bjorn.andersson@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 11/18/20 10:25 AM, Bjorn Andersson wrote:
> The Qualcomm SCM driver was never explicitly enabled in the defconfig.
> Instead it was (apparently) selected by DRM_MSM and by the recent change
> to make it tristate now became =m.
>
> Unfortunately this removes the ability for PINCTRL_MSM and ARM_SMMU to
> be =y and with deferred_probe_timeout defaulting to 0 this means that
> things such as UART, USB, PCIe and SDHCI probes with their dependencies
> ignored.
>
> The lack of pinctrl results in invalid pin configuration and the lack of
> iommu results in the system locking up as soon as any form of data
> transfer is attempted from any of the affected peripherals.
>
> Mark QCOM_SCM as builtin, to avoid this.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d129340a7ed1..287ccf98dc41 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -99,6 +99,7 @@ CONFIG_ARM_SCPI_PROTOCOL=y
>  CONFIG_RASPBERRYPI_FIRMWARE=y
>  CONFIG_INTEL_STRATIX10_SERVICE=y
>  CONFIG_INTEL_STRATIX10_RSU=m
> +CONFIG_QCOM_SCM=y
>  CONFIG_EFI_CAPSULE_LOADER=y
>  CONFIG_IMX_SCU=y
>  CONFIG_IMX_SCU_PD=y

Tested-by: Steev Klimaszewski <steev@kali.org>