Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3702362pxu;
        Mon, 30 Nov 2020 08:35:00 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwNK4WotVbPmwe3DXwFZfdGW2m5E1mXX7zyKF9KIGU09e1XxNWFNxByzxD93CD0Q/Cs5KOM
X-Received: by 2002:a17:906:1f8e:: with SMTP id t14mr1794871ejr.350.1606754099841;
        Mon, 30 Nov 2020 08:34:59 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1606754099; cv=none;
        d=google.com; s=arc-20160816;
        b=uZ1BC3NoMYi94raNXPU5vmnIPbbi0+33gAsbvdx2nXXhjsu9UYul8tqio772xYvy1j
         TD9enSsyxkEVUE+FqNbLk/OQOJtsyBVWlzbgwwIIAxdwHFWM1sEKX2oX3j+tSEJ0yGsU
         wP9/DIM4lZzrT8tF2eTAupFHIxqXnLGGOnDWJBYWuNZ1NwhscN3vTs8S6HcJpE4w/+xL
         d9uet2NRLvxqI/tTEC3YJVWBVGNa9MbyXq3E8VGpbiDp9y9Kobfp1EgzHJs/xBLE1D8Q
         u/g3ezu6jl/sb73pBiQpBqW7/y4S35cj30+1wJRA15BtqVeRvxxLAabeLOdYgccIdfvf
         m3+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=sy4KAX6jzm4XIGm84NdsBmciiAH8DotgRo5YfmCk2KM=;
        b=DOcKeyJ+oAptxTRFXQgOXNDinKMeZNxlyCjjbhkmyfToqeR98XMbJMhDsNuvyY6RN2
         1Zah5pK+Xp/hQr2TMd9OeVtgYbERDliaO3Hjgj+Ta1sYRWKR4HvSymEt5BDBSLXDF0r3
         IfXLJA83H6PPCIboeeLP29hUN+tcKqjFOorPdF1wrHm9NUT+p0OrmJgZfV2f+3s0ChcV
         XQWxNrxhZz7YswZhocR4dilkpNdGaHPtvNM95M6Fn1rYD390aVqBvuuluJAtHgX6m/IV
         cZD/PDJ2RxBb/Q8Q6KkdaJ0g420uKI2Qdn8qKPfqShgYbNn4D7AcoUTspyMgqLeC/Tu+
         b8JQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n19si10808060eda.345.2020.11.30.08.34.36;
        Mon, 30 Nov 2020 08:34:59 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728806AbgK3Qas (ORCPT <rfc822;1dalishi1@gmail.com> + 99 others);
        Mon, 30 Nov 2020 11:30:48 -0500
Received: from mx2.suse.de ([195.135.220.15]:58770 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725859AbgK3Qas (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Nov 2020 11:30:48 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 4A9A9AC55;
        Mon, 30 Nov 2020 16:30:07 +0000 (UTC)
Date:   Mon, 30 Nov 2020 17:30:06 +0100
From:   Daniel Wagner <dwagner@suse.de>
To:     Tom Rix <trix@redhat.com>
Cc:     njavali@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, GR-QLogic-Storage-Upstream@marvell.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro
 definition
Message-ID: <20201130163006.fvr4rs7524fymihu@beryllium.lan>
References: <20201127182741.2801597-1-trix@redhat.com>
 <20201130091753.4wyrzlbrqszdzy6s@beryllium.lan>
 <3baa674f-ce34-34a9-26ec-1d3e0e2ebdcd@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3baa674f-ce34-34a9-26ec-1d3e0e2ebdcd@redhat.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >>  #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
> >> -	atomic_dec(&__qpair->ref_count);		\
> >> +	atomic_dec(&__qpair->ref_count)		\
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> 
> How about removing the last escaped newline and the next empty line ?

Yes please.