Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201119142104.85566-1-alexandru.ardelean@analog.com>
 <CAHp75VdkomLMPYZbB7-KerGmyxXxB8hQuAjLtJ0bhB5f5vfuNA@mail.gmail.com> <CAMpxmJXbpiiKzxsrBk5mdLf1Kk5_-5pwJYOeCsTTqKmS2QUMTQ@mail.gmail.com>
In-Reply-To: <CAMpxmJXbpiiKzxsrBk5mdLf1Kk5_-5pwJYOeCsTTqKmS2QUMTQ@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 30 Nov 2020 19:16:59 +0200
Message-ID: <CAHp75Vd=S26VgrkcQoMN=xFburOn8207MUYbGzMBLHgn0iuErA@mail.gmail.com>
Subject: Re: [PATCH] gpio: xra1403: remove unneeded spi_set_drvdata()
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nandor Han <nandor.han@ge.com>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 30, 2020 at 6:37 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Thu, Nov 19, 2020 at 4:04 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Thu, Nov 19, 2020 at 4:17 PM Alexandru Ardelean
> > <alexandru.ardelean@analog.com> wrote:
> > >
> > > There is no matching spi_get_drvdata() call in the driver, so there is no
> > > need to do spi_set_drvdata(). This looks like it probably was copied from a
> > > driver that used both spi_set_drvdata() & spi_get_drvdata().
> >
> > While above luckily (*) okay it may not always be the case.
> >
> > *) it can be paired with dev_get_drvdata() which is usual for PM callbacks.
> >
> > With amended commit message
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
>
> I applied this patch. I wasn't sure exactly how you want the commit
> message to be changed - it sounds pretty clear to me so I took it.

For example, by adding " or dev_get_drvdata()" to the end.

-- 
With Best Regards,
Andy Shevchenko