Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp3743679pxu; Mon, 30 Nov 2020 09:22:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZqGFVJFPtoK5f6XwUIloB7L28eStZ5px/bdLe/HciMddoGmlUnV0htLeceqU2ddPgskh7 X-Received: by 2002:a17:906:81c6:: with SMTP id e6mr7136614ejx.257.1606756970270; Mon, 30 Nov 2020 09:22:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606756970; cv=none; d=google.com; s=arc-20160816; b=id2D/Np3gt2HjQSckxJe4Cp981Urj4hl/ZJxgAEsHY2nw66sVQQr8piRAyRqS2X5XS d9v+akNzqfDUvqi0Uc/sxfOUgXlQUed8QOCYrAB22DNXd1T7KjJDmCZhChjJoyks6xGd mhKydQ0SYAj1TQZ7Y2kneFY4u2rar3p8M+AiVLVbc94PgQU5w46bdKd+e2IOcN3OMroC xqWKgW3X2MtNF91u8PB6IJWd8nLJJXuvP3NK70i9Sfc/mSUrJEPnaDpghP+C3rXjMI// 4nHIVVMpvBnDnheahh7h6nKmTXZn/IdnUXIuDPPlsVa2mrqT03z5HZITvUQDoN1BcReA julw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=uCSXKg9oQju01GP5h0s6jqXQ6AFk/BXF7S69aDSMcJs=; b=1EQr9kQze7USIONGChLsohpAh0DSxDeC2yKheiAXVj4h7OywZhf37dGDzV6ZKYT6IG nOgHJ2IcUMAqz5/I1478JG3PYM9/dpRdjS7TSZnBXtXufuXe7Uou4vSb8Kr+uWYAH+Gw fhbJalm+ELpmlBSfTxo/S3QRXNRQEEQC5FD2LLpIL251v8ko3S3SOFo6htnA+aQS5V4s NmlpAcHNJEKLYpPoRdzZInVycvyf9YMgCefP1+3aInWDUQ43FtxoeM8nVHuZ2LyfJOKs 6LmbaZdhXLSnWRsmd1dc23nOT+B+iYg05E+KvUWfIV58HMBYMOgpGlbz+OpndhlG4xH8 w0qA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nt21si2416872ejb.739.2020.11.30.09.22.27; Mon, 30 Nov 2020 09:22:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbgK3RUq (ORCPT + 99 others); Mon, 30 Nov 2020 12:20:46 -0500 Received: from netrider.rowland.org ([192.131.102.5]:34807 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728794AbgK3RUq (ORCPT ); Mon, 30 Nov 2020 12:20:46 -0500 Received: (qmail 967969 invoked by uid 1000); 30 Nov 2020 12:20:04 -0500 Date: Mon, 30 Nov 2020 12:20:04 -0500 From: Alan Stern To: Hans de Goede Cc: Greg KH , Tom Yan , Christoph Hellwig , linux-usb , Mathias Nyman , Linux Kernel Mailing List , linux-pci@vger.kernel.org, Lu Baolu Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host() Message-ID: <20201130172004.GA966032@rowland.harvard.edu> References: <09992cec-65e4-2757-aae6-8fb02a42f961@redhat.com> <20201128154849.3193-1-tom.ty89@gmail.com> <20201128154849.3193-2-tom.ty89@gmail.com> <5e62c383-22ea-6df6-5acc-5e9f381d4632@redhat.com> <186eb035-4bc4-ff72-ee41-aeb6d81888e3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote: > Hi, > > On 11/30/20 2:30 PM, Greg KH wrote: > > On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/30/20 1:58 PM, Tom Yan wrote: > >>> It's merely a moving of comment moving for/and a no-behavioral-change > >>> adaptation for the reversion.> > >> > >> IMHO the revert of the troublesome commit and the other/new changes really > >> should be 2 separate commits. But I will let Alan and Greg have the final > >> verdict on this. > > > > I would prefer to just revert the commits and not do anything > > different/special here so late in the release cycle. > > > > So, if Alan agrees, I'll be glad to do them on my end, I just need the > > commit ids for them. > > The troublesome commit are (in reverse, so revert, order): > > 5df7ef7d32fe ("uas: bump hw_max_sectors to 2048 blocks for SS or faster drives") > 558033c2828f ("uas: fix sdev->host->dma_dev") > 0154012f8018 ("usb-storage: fix sdev->host->dma_dev") > > Alan, the reason for reverting these is that using scsi_add_host_with_dma() as the > last 2 patches do, with the dmadev argument of that call pointing to the device > for the XHCI controller is causing changes to the DMA settings of the XHCI controller > itself which is causing regressions in 5.10, see this email thread: > > https://lore.kernel.org/linux-usb/fde7e11f-5dfc-8348-c134-a21cb1116285@redhat.com/T/#t It's hard to go wrong with reverting, so it's okay with me. Still, Hans, have you checked out the difference between the scsi_add_host() and scsi_add_host_with_dma() calls? It's just a matter of using dev vs. sysdev. In particular, have you checked to see what those two devices are on your system? It seems likely that if one of those calls messes up some DMA settings, the other one does too -- just maybe not settings that matter much. Alan Stern