Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Shawn Guo <shawn.guo@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201130170028.319798-1-bjorn.andersson@linaro.org>
From:   Steev Klimaszewski <steev@kali.org>
Message-ID: <58cf6829-4121-db46-04f7-0dc6c59b2053@kali.org>
Date:   Mon, 30 Nov 2020 11:25:58 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <20201130170028.319798-1-bjorn.andersson@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 11/30/20 11:00 AM, Bjorn Andersson wrote:
> The "pins" property takes an array of pin _names_, not pin numbers. Fix
> this.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 399aef2a0951..bb314973eb0c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -432,7 +432,7 @@ &tlmm {
>  	gpio-reserved-ranges = <0 4>, <81 4>;
>  
>  	i2c3_hid_active: i2c2-hid-active {
> -		pins = <37>;
> +		pins = "gpio37";
>  		function = "gpio";
>  
>  		input-enable;
> @@ -441,7 +441,7 @@ i2c3_hid_active: i2c2-hid-active {
>  	};
>  
>  	i2c5_hid_active: i2c5-hid-active {
> -		pins = <125>;
> +		pins = "gpio125";
>  		function = "gpio";
>  
>  		input-enable;
> @@ -450,7 +450,7 @@ i2c5_hid_active: i2c5-hid-active {
>  	};
>  
>  	i2c11_hid_active: i2c11-hid-active {
> -		pins = <92>;
> +		pins = "gpio92";
>  		function = "gpio";
>  
>  		input-enable;
> @@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active {
>  	};
>  
>  	wcd_intr_default: wcd_intr_default {
> -		pins = <54>;
> +		pins = "gpio54";
>  		function = "gpio";
>  
>  		input-enable;

Tested-by: Steev Klimaszewski <steev@kali.org>