Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-12-lee.jones@linaro.org>
In-Reply-To: <20201126134240.3214176-12-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 30 Nov 2020 18:31:50 -0500
Message-ID: <CADnq5_ORvcezYqvKv6xs8JKKFDxZ=Lrm9GOCxYBeJ8-fJAd0wg@mail.gmail.com>
Subject: Re: [PATCH 11/40] drm/amd/pm/powerplay/hwmgr/ppevvmath: Place
 variable declaration under same clause as its use
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Evan Quan <evan.quan@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h: In functio=
n =E2=80=98fMultiply=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:22: war=
ning: variable =E2=80=98Y_LessThanOne=E2=80=99 set but not used [-Wunused-b=
ut-set-variable]
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:7: warn=
ing: variable =E2=80=98X_LessThanOne=E2=80=99 set but not used [-Wunused-bu=
t-set-variable]
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h b/drivers=
/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> index 8f50a038396ce..dac29fe6cfc6f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h
> @@ -333,14 +333,14 @@ static fInt fMultiply (fInt X, fInt Y) /* Uses 64-b=
it integers (int64_t) */
>  {
>         fInt Product;
>         int64_t tempProduct;
> +
> +       /*The following is for a very specific common case: Non-zero numb=
er with ONLY fractional portion*/
> +       /* TEMPORARILY DISABLED - CAN BE USED TO IMPROVE PRECISION
>         bool X_LessThanOne, Y_LessThanOne;
>
>         X_LessThanOne =3D (X.partial.real =3D=3D 0 && X.partial.decimal !=
=3D 0 && X.full >=3D 0);
>         Y_LessThanOne =3D (Y.partial.real =3D=3D 0 && Y.partial.decimal !=
=3D 0 && Y.full >=3D 0);
>
> -       /*The following is for a very specific common case: Non-zero numb=
er with ONLY fractional portion*/
> -       /* TEMPORARILY DISABLED - CAN BE USED TO IMPROVE PRECISION
> -
>         if (X_LessThanOne && Y_LessThanOne) {
>                 Product.full =3D X.full * Y.full;
>                 return Product
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel