Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4016732pxu; Mon, 30 Nov 2020 15:45:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2e6hX0/+ONwglyvluNmTJ7K3FLGzMTSd0PTyBETqF61D1nHUbwoivUaAWhSDZd30KAL4Q X-Received: by 2002:a50:b205:: with SMTP id o5mr177463edd.304.1606779938187; Mon, 30 Nov 2020 15:45:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606779938; cv=none; d=google.com; s=arc-20160816; b=zWxHpVRBRYeZ7brMJ8ahXCnipwY+wRlLDHWKia1/PyKp1BO4awT+aeRnf7U5HW5pAQ CVo/hHKorA+19buvdfi4gkFbF69VfCg9/IJn/K1VKHZA49tymkAbtd/dSkAry6j6x9Lg CqbUk8PYCp6clphVvoESRUMKIKLcfh8lqDfulXyFugh5lPymtd/jbRbUJz7ZntrxTpzS lgQXuGfD/SpmEJtrBxEiwdf5JEvquJ5z3msE8BiH9r8yE5cN4eHrXTap/bHPRtwMAh8Q E7j6klQ16oTKINZevUrKZeCKTl9O9nPTa78xiajqTKUntukRYxy8mXpxyZCBch+3mQRr 1F4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=JGvE1dbOKda2/WHrIP/Ro/kGamBbUtD5RKgL7QaldPU=; b=hwCzgmquPdt4pBMkInc+xjRl6eP8xUsE4SH1Sot7aNHOPsVm30cENB+/2o1PGse+iE m2/+EFqFHY/XV8nv6JLq89vkzpNqB4hzrHZ2tqC5Cxo+UCoyzDF+nZUyluAw39QPgDJm wh6GcUGyjfGljzJbFiQx1qFlk/OPgtZnYRNQt5v4wUKm6SVV2z3M+nOzqQygYMQFni7P YbkvItSDSO/udACQKk5KNRFzM+uynActqQXiqFKN4FpxGS8KfcXouTMIqsNsb7d4KKsS VABON5aSLreju/o/i8FSd2yhHN8QMPeHr3nhvGRkpmbGKQbJmyvhwLGUBvtjjz/he39l 0V6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si10853112ejz.621.2020.11.30.15.45.13; Mon, 30 Nov 2020 15:45:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729524AbgK3Xnn (ORCPT + 99 others); Mon, 30 Nov 2020 18:43:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58712 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729078AbgK3Xnn (ORCPT ); Mon, 30 Nov 2020 18:43:43 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kjsD9-009b1o-Vw; Tue, 01 Dec 2020 00:03:59 +0100 Date: Tue, 1 Dec 2020 00:03:59 +0100 From: Andrew Lunn To: Aryan Srivastava Cc: robh+dt@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chris.packham@alliedtelesis.co.nz Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Message-ID: <20201130230359.GH2073444@lunn.ch> References: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130223507.23571-1-aryan.srivastava@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: > Add device tree file for x530 board. This has an Armada 385 SoC. Has > NAND-flash for user storage and SPI for booting. Covers majority of x530 > and GS980MX variants. Hi Aryan What exactly does that mean, it covers most variants? I'm just wondering if this should be a .dtsi file, and then each variant has a .dts file specific to it? Or is the hardware itself the same, and only the software varies between the variants? Andrew