Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-29-lee.jones@linaro.org>
In-Reply-To: <20201126134240.3214176-29-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 30 Nov 2020 18:52:20 -0500
Message-ID: <CADnq5_O8E5mfdbpeqXDovWCCFfjMchVfwt60uStL34LT=zdV6g@mail.gmail.com>
Subject: Re: [PATCH 28/40] drm/amd/pm/powerplay/hwmgr/smu_helper: Demote or
 fix kernel-doc headers
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Evan Quan <evan.quan@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warni=
ng: Function parameter or member 'hwmgr' not described in 'phm_wait_on_regi=
ster'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warni=
ng: Function parameter or member 'index' not described in 'phm_wait_on_regi=
ster'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warni=
ng: Function parameter or member 'value' not described in 'phm_wait_on_regi=
ster'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warni=
ng: Function parameter or member 'mask' not described in 'phm_wait_on_regis=
ter'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:145: warni=
ng: Function parameter or member 'hwmgr' not described in 'phm_wait_on_indi=
rect_register'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:145: warni=
ng: Function parameter or member 'indirect_port' not described in 'phm_wait=
_on_indirect_register'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:145: warni=
ng: Function parameter or member 'index' not described in 'phm_wait_on_indi=
rect_register'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:145: warni=
ng: Function parameter or member 'value' not described in 'phm_wait_on_indi=
rect_register'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:145: warni=
ng: Function parameter or member 'mask' not described in 'phm_wait_on_indir=
ect_register'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:494: warni=
ng: Function parameter or member 'hwmgr' not described in 'phm_initializa_d=
ynamic_state_adjustment_rule_settings'
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c b/driver=
s/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> index 2a0ca5194bbe9..bfe80ac0ad8c8 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c
> @@ -103,7 +103,7 @@ uint32_t phm_set_field_to_u32(u32 offset, u32 origina=
l_data, u32 field, u32 size
>         return original_data;
>  }
>
> -/**
> +/*
>   * Returns once the part of the register indicated by the mask has
>   * reached the given value.
>   */
> @@ -132,7 +132,7 @@ int phm_wait_on_register(struct pp_hwmgr *hwmgr, uint=
32_t index,
>  }
>
>
> -/**
> +/*
>   * Returns once the part of the register indicated by the mask has
>   * reached the given value.The indirect space is described by giving
>   * the memory-mapped index of the indirect index register.
> @@ -486,9 +486,9 @@ int phm_get_sclk_for_voltage_evv(struct pp_hwmgr *hwm=
gr,
>  }
>
>  /**
> - * Initialize Dynamic State Adjustment Rule Settings
> + * phm_initializa_dynamic_state_adjustment_rule_settings - Initialize Dy=
namic State Adjustment Rule Settings
>   *
> - * @param    hwmgr  the address of the powerplay hardware manager.
> + * @hwmgr:  the address of the powerplay hardware manager.
>   */
>  int phm_initializa_dynamic_state_adjustment_rule_settings(struct pp_hwmg=
r *hwmgr)
>  {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel