Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: asutoshd=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 29D16C43460
Subject: Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage
 values
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Stanley Chu <stanley.chu@mediatek.com>, linux-scsi@vger.kernel.org,
        martin.petersen@oracle.com, avri.altman@wdc.com,
        alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com,
        cang@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        nguyenb@codeaurora.org, kuohong.wang@mediatek.com,
        peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
        andy.teng@mediatek.com, chaotian.jing@mediatek.com,
        cc.chou@mediatek.com, jiajie.hao@mediatek.com,
        alice.chao@mediatek.com
References: <20201130091610.2752-1-stanley.chu@mediatek.com>
 <568660cd-80e6-1b8f-d426-4614c9159ff4@codeaurora.org>
 <X8V83T+Tx6teNLOR@builder.lan>
From:   "Asutosh Das (asd)" <asutoshd@codeaurora.org>
Message-ID: <4335d590-0506-d920-8e7f-f0f0372780f9@codeaurora.org>
Date:   Mon, 30 Nov 2020 15:54:20 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <X8V83T+Tx6teNLOR@builder.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/30/2020 3:14 PM, Bjorn Andersson wrote:
> On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote:
> 
>> On 11/30/2020 1:16 AM, Stanley Chu wrote:
>>> UFS specficication allows different VCC configurations for UFS devices,
>>> for example,
>>> 	(1). 2.70V - 3.60V (By default)
>>> 	(2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in
>>>                             device tree)
>>> 	(3). 2.40V - 2.70V (Supported since UFS 3.x)
>>>
>>> With the introduction of UFS 3.x products, an issue is happening that
>>> UFS driver will use wrong "min_uV/max_uV" configuration to toggle VCC
>>> regulator on UFU 3.x products with VCC configuration (3) used.
>>>
>>> To solve this issue, we simply remove pre-defined initial VCC voltage
>>> values in UFS driver with below reasons,
>>>
>>> 1. UFS specifications do not define how to detect the VCC configuration
>>>      supported by attached device.
>>>
>>> 2. Device tree already supports standard regulator properties.
>>>
>>> Therefore VCC voltage shall be defined correctly in device tree, and
>>> shall not be changed by UFS driver. What UFS driver needs to do is simply
>>> enabling or disabling the VCC regulator only.
>>>
>>> This is a RFC conceptional patch. Please help review this and feel
>>> free to feedback any ideas. Once this concept is accepted, and then
>>> I would post a more completed patch series to fix this issue.
>>>
>>> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
>>> ---
>>>    drivers/scsi/ufs/ufshcd-pltfrm.c | 10 +---------
>>>    1 file changed, 1 insertion(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
>>> index a6f76399b3ae..3965be03c136 100644
>>> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
>>> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
>>> @@ -133,15 +133,7 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
>>>    		vreg->max_uA = 0;
>>>    	}
>>> -	if (!strcmp(name, "vcc")) {
>>> -		if (of_property_read_bool(np, "vcc-supply-1p8")) {
>>> -			vreg->min_uV = UFS_VREG_VCC_1P8_MIN_UV;
>>> -			vreg->max_uV = UFS_VREG_VCC_1P8_MAX_UV;
>>> -		} else {
>>> -			vreg->min_uV = UFS_VREG_VCC_MIN_UV;
>>> -			vreg->max_uV = UFS_VREG_VCC_MAX_UV;
>>> -		}
>>> -	} else if (!strcmp(name, "vccq")) {
>>> +	if (!strcmp(name, "vccq")) {
>>>    		vreg->min_uV = UFS_VREG_VCCQ_MIN_UV;
>>>    		vreg->max_uV = UFS_VREG_VCCQ_MAX_UV;
>>>    	} else if (!strcmp(name, "vccq2")) {
>>>
>>
>> Hi Stanley
>>
>> Thanks for the patch. Bao (nguyenb) was also working towards something
>> similar.
>> Would it be possible for you to take into account the scenario in which the
>> same platform supports both 2.x and 3.x UFS devices?
>>
>> These've different voltage requirements, 2.4v-3.6v.
>> I'm not sure if standard dts regulator properties can support this.
>>
> 
> What is the actual voltage requirement for these devices and how does
> the software know what voltage to pick in this range?
> 
> Regards,
> Bjorn
> 
>> -asd
>>
>>
>> -- 
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> Linux Foundation Collaborative Project

For platforms that support both 2.x (2.7v-3.6v) and 3.x (2.4v-2.7v), the 
voltage requirements (Vcc) are 2.4v-3.6v. The software initializes the 
ufs device at 2.95v & reads the version and if the device is 3.x, it may 
do the following:
- Set the device power mode to SLEEP
- Disable the Vcc
- Enable the Vcc and set it to 2.5v
- Set the device power mode to ACTIVE

All of the above may be done at HS-G1 & moved to max supported gear 
based on the device version, perhaps?

Am open to other ideas though.

-asd

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project