Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4060954pxu; Mon, 30 Nov 2020 16:58:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKMwep3qVi1HLAbRqVfeSdMMIzHrJ8QPYoffSGrml7Ket76V9D7s8IAjuVyIZpn8pMkZyh X-Received: by 2002:a17:906:7d98:: with SMTP id v24mr537523ejo.129.1606784283599; Mon, 30 Nov 2020 16:58:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606784283; cv=none; d=google.com; s=arc-20160816; b=bZmmhauuMIzKMBBOl6ZMN6KGRB5PrqcW76mDH0dDobCE+xktbhI1OSmuiqcYqjuQgA Le6ZkRoO/nP4Vhzu6krCmSADdry3/pIw0iWnWiVlkPKmgvcC1a7igYSHqShXgBcD+k9K w3h8z2dF6NI6rRhcnwcTUuAd8SU2axqJ4rssp+AaoPtAj+iEsIUr6V2r+lQKRfedmigy EGszGozRu9e/C//iVS76d4qu99XtdRLMldLnFgkmAi1PGGhVisXe4ng7vnUpUoxqcRn4 EUWkmWrM6JNs90+QOgqxjIGjiPcp1yXAYxIO5HyvmkpangSi5uB5Zk2xIaQxuxkSF628 GUyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=LTvzjnUasfQga5e1lDNmTwRz9awEcnylv+6mu9MIy/I=; b=Qn72cPZGLEIVi7Ci+nYr/ev+ErmMSnqU06loNYuMyIQbifo/d5N4QeZhML+jOvPTln zLyombEt+URmeFWHHjDichL3cXD2lQ/HONawyvflz63KZ1Vb2Y6tprSNYQao9+IOX77G ujabFXs+uEdZHpDU+0dqP+ZXx+6n86UIeE9gCLZ6RnhaOhJFdkSkbEXXYTkAlAOVVYbk SzmzHJ7ZH4wwp+RZCwJW8ULzmqUJiFWoXuAFRNQOsqwUPJrfOohbdo/5JuoScP4Ej1nz l6etdzRrWhgBbusjHB/lbZIBsXgquMHnOypdBK7NUvAm3Sgvcgii5+H/5odQW1S/S26D qNJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si106577edq.549.2020.11.30.16.57.41; Mon, 30 Nov 2020 16:58:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389166AbgLAAzg (ORCPT + 99 others); Mon, 30 Nov 2020 19:55:36 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:8477 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728774AbgLAAzf (ORCPT ); Mon, 30 Nov 2020 19:55:35 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4ClNsh6sS1zhkBm; Tue, 1 Dec 2020 08:54:32 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 1 Dec 2020 08:54:46 +0800 From: Tian Tao To: CC: , Subject: [PATCH] power: supply: ab8500_charger: Fix missing IRQF_ONESHOT as only threaded handler Date: Tue, 1 Dec 2020 08:55:05 +0800 Message-ID: <1606784105-31729-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coccinelle noticed: drivers/power/supply/ab8500_charger.c:3605:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Tian Tao --- drivers/power/supply/ab8500_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c index db65be0..7dbe18d 100644 --- a/drivers/power/supply/ab8500_charger.c +++ b/drivers/power/supply/ab8500_charger.c @@ -3603,7 +3603,7 @@ static int ab8500_charger_probe(struct platform_device *pdev) } ret = request_threaded_irq(irq, NULL, ab8500_charger_irq[i].isr, - IRQF_SHARED | IRQF_NO_SUSPEND, + IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT, ab8500_charger_irq[i].name, di); if (ret != 0) { -- 2.7.4