Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: asutoshd=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D4516C433C6
Subject: Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code
To:     Can Guo <cang@codeaurora.org>, nguyenb@codeaurora.org,
        hongwus@codeaurora.org, rnayak@codeaurora.org,
        linux-scsi@vger.kernel.org, kernel-team@android.com,
        saravanak@google.com, salyzyn@google.com
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Satya Tangirala <satyat@google.com>,
        open list <linux-kernel@vger.kernel.org>
References: <1606442334-22641-1-git-send-email-cang@codeaurora.org>
From:   "Asutosh Das (asd)" <asutoshd@codeaurora.org>
Message-ID: <ce5e6132-8284-c2c5-3eaa-78d400763534@codeaurora.org>
Date:   Mon, 30 Nov 2020 14:54:52 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <1606442334-22641-1-git-send-email-cang@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/26/2020 5:58 PM, Can Guo wrote:
> Instead of making the scale down gear a hard code, make it a member of
> ufs_clk_scaling struct.
> 
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---

Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>

>   drivers/scsi/ufs/ufshcd.c | 12 +++++++-----
>   drivers/scsi/ufs/ufshcd.h |  2 ++
>   2 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 44254c9..1789df3 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1100,7 +1100,6 @@ static int ufshcd_wait_for_doorbell_clr(struct ufs_hba *hba,
>    */
>   static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up)
>   {
> -	#define UFS_MIN_GEAR_TO_SCALE_DOWN	UFS_HS_G1
>   	int ret = 0;
>   	struct ufs_pa_layer_attr new_pwr_info;
>   
> @@ -1111,16 +1110,16 @@ static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up)
>   		memcpy(&new_pwr_info, &hba->pwr_info,
>   		       sizeof(struct ufs_pa_layer_attr));
>   
> -		if (hba->pwr_info.gear_tx > UFS_MIN_GEAR_TO_SCALE_DOWN
> -		    || hba->pwr_info.gear_rx > UFS_MIN_GEAR_TO_SCALE_DOWN) {
> +		if (hba->pwr_info.gear_tx > hba->clk_scaling.min_gear ||
> +		    hba->pwr_info.gear_rx > hba->clk_scaling.min_gear) {
>   			/* save the current power mode */
>   			memcpy(&hba->clk_scaling.saved_pwr_info.info,
>   				&hba->pwr_info,
>   				sizeof(struct ufs_pa_layer_attr));
>   
>   			/* scale down gear */
> -			new_pwr_info.gear_tx = UFS_MIN_GEAR_TO_SCALE_DOWN;
> -			new_pwr_info.gear_rx = UFS_MIN_GEAR_TO_SCALE_DOWN;
> +			new_pwr_info.gear_tx = hba->clk_scaling.min_gear;
> +			new_pwr_info.gear_rx = hba->clk_scaling.min_gear;
>   		}
>   	}
>   
> @@ -1824,6 +1823,9 @@ static void ufshcd_init_clk_scaling(struct ufs_hba *hba)
>   	if (!ufshcd_is_clkscaling_supported(hba))
>   		return;
>   
> +	if (!hba->clk_scaling.min_gear)
> +		hba->clk_scaling.min_gear = UFS_HS_G1;
> +
>   	INIT_WORK(&hba->clk_scaling.suspend_work,
>   		  ufshcd_clk_scaling_suspend_work);
>   	INIT_WORK(&hba->clk_scaling.resume_work,
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 6f0f2d4..bdab23e 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -385,6 +385,7 @@ struct ufs_saved_pwr_info {
>    * @workq: workqueue to schedule devfreq suspend/resume work
>    * @suspend_work: worker to suspend devfreq
>    * @resume_work: worker to resume devfreq
> + * @min_gear: lowest HS gear to scale down to
>    * @is_allowed: tracks if scaling is currently allowed or not
>    * @is_busy_started: tracks if busy period has started or not
>    * @is_suspended: tracks if devfreq is suspended or not
> @@ -399,6 +400,7 @@ struct ufs_clk_scaling {
>   	struct workqueue_struct *workq;
>   	struct work_struct suspend_work;
>   	struct work_struct resume_work;
> +	u32 min_gear;
>   	bool is_allowed;
>   	bool is_busy_started;
>   	bool is_suspended;
> 


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project