Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tPvpeZSgCe+NVvNxdXjRROenaHNdhlNMLckC90/aLPKtL7c98dxv85ySzmvwWRmIN1mPj428cg
 pZfCxBukzooA==
IronPort-SDR: /mW1ORI8gJYO/d4eXbn0W7cBdywJ1g3/aMylkXFWWOT8rwUY/M67xXZW7gYpcQXTYKk5LkZWrn
 H7L87bh90mqw==
Subject: Re: [PATCH] sched/fair: Clear SMT siblings after determining the core
 is not idle
To:     Vincent Guittot <vincent.guittot@linaro.org>,
        Mel Gorman <mgorman@techsingularity.net>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20201130144020.GS3371@techsingularity.net>
 <CAKfTPtBcZnxR073=eRsWNAGOnA8K4emL0BYEUzbkzZx6qJWmSg@mail.gmail.com>
From:   "Li, Aubrey" <aubrey.li@linux.intel.com>
Message-ID: <f31178dd-34e4-0e9d-e8e3-fda396641daf@linux.intel.com>
Date:   Tue, 1 Dec 2020 09:04:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <CAKfTPtBcZnxR073=eRsWNAGOnA8K4emL0BYEUzbkzZx6qJWmSg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020/11/30 22:47, Vincent Guittot wrote:
> On Mon, 30 Nov 2020 at 15:40, Mel Gorman <mgorman@techsingularity.net> wrote:
>>
>> The clearing of SMT siblings from the SIS mask before checking for an idle
>> core is a small but unnecessary cost. Defer the clearing of the siblings
>> until the scan moves to the next potential target. The cost of this was
>> not measured as it is borderline noise but it should be self-evident.
> 
> Good point

This is more reasonable, thanks Mel.

> 
>>
>> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> 
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> 
>> ---
>>  kernel/sched/fair.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 0d54d69ba1a5..d9acd55d309b 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -6087,10 +6087,11 @@ static int select_idle_core(struct task_struct *p, struct sched_domain *sd, int
>>                                 break;
>>                         }
>>                 }
>> -               cpumask_andnot(cpus, cpus, cpu_smt_mask(core));
>>
>>                 if (idle)
>>                         return core;
>> +
>> +               cpumask_andnot(cpus, cpus, cpu_smt_mask(core));
>>         }
>>
>>         /*