Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4136374pxu; Mon, 30 Nov 2020 19:07:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPAvCCjWrTolrhcwob8rKU9XjOzVPR0A15ExNIi/G0flwVlE8PJ+koDI9tSvHECXNnaDRu X-Received: by 2002:a17:906:6546:: with SMTP id u6mr1101086ejn.36.1606792064187; Mon, 30 Nov 2020 19:07:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606792064; cv=none; d=google.com; s=arc-20160816; b=Wu8lNyplVTp/nSe4c9vxCHOehttIDgn0LQCk29e1BywnJ11sGbcmPpmgehgSoxa8Nl zNCLzWDRQb6qICn+biSDbRw1VPMCVpi4IN6igv0h0Lc1y5xldMAZDJcrmlq+NPkD+lM2 N/CFgSMJ7HB0nAUkq7UNrEKETBKpUWrCXiXWogOKLyjQYbakVQARw9JBOd0NYYc7cgo0 3+HW8OYQu0jpNmEYBbM98Z1ROmuKHd9mz9LMDH8ba4ilUdlvK6mVQqQH3yS5oPTTlbC6 A2psPnR7M38wSLToGKmCz8TK5RyGerIlMuZYlgPUctLCnRaz63hVIZCKoLsgfoq3V2rI XIVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:references:cc:to:from :subject; bh=3gNpoSxwYDrz62qbh0nt2xrmigPRV3Xr4GTlipLtSVM=; b=wllENZEpXvVQiLO2BhpqzgEHpMzeRtjikJg2tsu6voj6xIZ8zGE/dpXTtIjzNLrWV1 +yBykQRqZYWHlq2XB3meJ4vw+dA4R9xKIyFIEny8lXcMAI27w6AJfqgIJ4abPw2WaP9s fhlfL9eyLJvnw+G25k6fKPIQ5rn4LMPHNh0HG32pj7I2fFAPkmUtjHfsjUzCi4U69gvE kXP5cwRQl1t4aOLkwP+7abW4TsPRMWtCB3HQevZ20xiY7dvljcMGw4y7WYvYkfQSfRzx u5YzDKCwI76PEWLzbyot1F/3sL65T6xBPfrcK6pvWOWu+RdzkKm65tnGPBbrrUjsd1Tr Zu2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt24si327173edb.7.2020.11.30.19.07.21; Mon, 30 Nov 2020 19:07:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbgLADEL (ORCPT + 99 others); Mon, 30 Nov 2020 22:04:11 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:8894 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgLADEL (ORCPT ); Mon, 30 Nov 2020 22:04:11 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4ClRjz2zpBz76F5; Tue, 1 Dec 2020 11:03:03 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 1 Dec 2020 11:03:27 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe From: Zheng Zengkai To: CC: , , Neil Armstrong , , , , , Martin Blumenstingl References: <20201111095256.10477-1-zhengzengkai@huawei.com> <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Message-ID: Date: Tue, 1 Dec 2020 11:03:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe and Greg, > Ping... > >> On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai >> wrote: >>> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >>> on one error handling path. This patch fixes that. >>> >>> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY >>> initialization on G12A and A1 SoCs") >>> Reported-by: Hulk Robot >>> Signed-off-by: Zheng Zengkai >> Reviewed-by: Martin Blumenstingl >> >> many thanks for this fix! >> >> >> Best regards >> Martin >> >> . Could you please get round to taking a glance and giving me a reply? ;-) Thank you very much! Best regards Zengkai