Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 20:27:15 -0800
From:   Moritz Fischer <mdf@kernel.org>
To:     Sonal Santan <sonal.santan@xilinx.com>
Cc:     linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org,
        maxz@xilinx.com, lizhih@xilinx.com, michal.simek@xilinx.com,
        stefanos@xilinx.com, devicetree@vger.kernel.org
Subject: Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files
Message-ID: <X8XGI7yRAX+xAeqQ@archbook>
References: <20201129000040.24777-1-sonals@xilinx.com>
 <20201129000040.24777-3-sonals@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201129000040.24777-3-sonals@xilinx.com>
Precedence: bulk

Hi Sonal,

On Sat, Nov 28, 2020 at 04:00:34PM -0800, Sonal Santan wrote:
> From: Sonal Santan <sonal.santan@xilinx.com>
> 
> Add XRT UAPI header files which describe flash layout, XRT
> mailbox protocol, xclBin/axlf FPGA image container format and
> XRT management physical function driver ioctl interfaces.
> 
> flash_xrt_data.h:
> Layout used by XRT to store private data on flash.
> 
> mailbox_proto.h:
> Mailbox opcodes and high level data structures representing
> various kinds of information like sensors, clock, etc.
> 
> mailbox_transport.h:
> Transport protocol used by mailbox.
> 
> xclbin.h:
> Container format used to store compiled FPGA image which includes
> bitstream and metadata.

Can these headers be introduced together with the code that uses them as
logical change?

I haven't looked too closely, but it helps reviewing if you can break it
into smaller pieces that can stand by themselves.

Thanks,
Moritz