Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4181692pxu; Mon, 30 Nov 2020 20:50:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJziv8DF8nV9xqbiFUPEmTSGxNYlxgt04tmAqBUPMlPOhmf6BbyMoCVnDXmJnvrpZquSSmp1 X-Received: by 2002:aa7:dbc3:: with SMTP id v3mr1233398edt.199.1606798240851; Mon, 30 Nov 2020 20:50:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606798240; cv=none; d=google.com; s=arc-20160816; b=gcJCH3lE14wP652YhakJ792bT2WeCBAflFY9ql/kGvBLPTD8WVSxY6qQq3b8ZVs5pL aC8cDjXgfEGdR73l9z6TitY2KNLOUlDoJxN0w9Sdo4OiXog5Y7NnwymrsN26ibAqXMC5 Flt4EAz4KywDsZS4a9DbuB2/j0+2iblt7xQwnC8xK6v3PnlY4QeYKjPtzZI6agl1RsFY naVrP2pHEv6RIHyy18Se55qINQogJrgdRHXK8W57gLDl7D6yZsuJSkxhCiNWibPIEXuv Kw1qfO7+T3Mqo6SyrZOkc5CLC4Sv/rUlV+bR7GgRM8d4zRgbJPq5Rjj3vIOXPWJaBFQK QZMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=DeB8Vzw3aLX4KP7kVRUoCP7Ijj+R0v5gEtQH6VBGpEU=; b=as2syJsTlDoyc5LR/fbzk0qy8BowIemo8qKIQ3FgiyDE+HbcOrbEEcTKBIsMrppIsu pS0XkDeqkH31Y0VFcLAP1yAveub6zbAGq7tMxBJGPmGfsGOLk4OOBtT+KHF1DUxFZEA4 cwvO5iYAvwGjwB7r2ZMCbm8xHdJPgDy4+SwM3fAqjIMeDOnZaVmO9VOKciEovrKVgaQ3 mMjvxmyMqRKxqxd9Mn7iCGATjdqup6w6qtRzQJqYWIAI2t0KvLcGWNt5N0LHfJfuEH8v Aspu7mElSZUnSQYUbaJr18XhHx0Mk2jt2Nt4rQ13ph0endaKxPt2Scxo+pOtx925UOmy lDiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=dUqdqu5M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o4si452475edj.19.2020.11.30.20.50.18; Mon, 30 Nov 2020 20:50:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=dUqdqu5M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728546AbgLAEpw (ORCPT + 99 others); Mon, 30 Nov 2020 23:45:52 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58532 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728229AbgLAEpw (ORCPT ); Mon, 30 Nov 2020 23:45:52 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B14ZMT5101662; Tue, 1 Dec 2020 04:44:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=DeB8Vzw3aLX4KP7kVRUoCP7Ijj+R0v5gEtQH6VBGpEU=; b=dUqdqu5M7crntrMIUjrHZLWaRLnNfxk6HIZyTpZ7HKliM79E6g8696tVKXi5Xbv1iMVB c0G+UzobbktlCnE6Xep9L1EDM3bwPKksSRj/Cti2Ywr2/aOFBa0nXflKRnoBT7MaEl6v Fd0HbhkXlHiS6vOBDJ3LKbWmOq/jWsdsiHPs3jfQVrCy9PR7hCRpbLVyImJd3jvEjh8h np6cytw+itxZnjWVIGtEwrI2a9cIoThK6nGX9tmW3Fd989f4kGvFxDAqUxrCpHGMX/ko Ro+E0iynjx6P1GsA1LBmkGbyI/AHOEkHq+SdZfCw25AmFbKaQuj/iM2Bt7LYrsVbUQTG Qw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 353dyqgj8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 01 Dec 2020 04:44:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B14ZI3p010238; Tue, 1 Dec 2020 04:44:54 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 3540fw9w9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Dec 2020 04:44:54 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0B14ikFG007908; Tue, 1 Dec 2020 04:44:47 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Nov 2020 20:44:46 -0800 To: Bean Huo Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: ufs: Remove unnecessary if condition in ufshcd_suspend() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201125185300.3394-1-huobean@gmail.com> Date: Mon, 30 Nov 2020 23:44:43 -0500 In-Reply-To: <20201125185300.3394-1-huobean@gmail.com> (Bean Huo's message of "Wed, 25 Nov 2020 19:53:00 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9821 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=1 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010031 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9821 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 clxscore=1011 mlxscore=0 spamscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=1 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010031 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bean, > In the case that auto_bkops_enable is false, which means auto bkops > has been disabled, so no need to call ufshcd_disable_auto_bkops(). Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering