Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Dec 2020 13:20:49 +0800
From:   Eric Lin <tesheng@andestech.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "walken@google.com" <walken@google.com>,
        "daniel.m.jordan@oracle.com" <daniel.m.jordan@oracle.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "penberg@kernel.org" <penberg@kernel.org>,
        "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
        "palmer@dabbelt.com" <palmer@dabbelt.com>,
        "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
        "dslin1010@gmail.com" <dslin1010@gmail.com>,
        "Alan Quey-Liang Kao(?????})" <alankao@andestech.com>
Subject: Re: [PATCH] riscv/mm: Prevent kernel module access user-space memory
 without uaccess routines
Message-ID: <20201201052048.GA7647@atcfdc88>
References: <20201130053037.27006-1-tesheng@andestech.com>
 <20201130083015.GA14676@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20201130083015.GA14676@infradead.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Nov 30, 2020 at 04:30:15PM +0800, Christoph Hellwig wrote:
Hi Christoph,
> > +	if (!user_mode(regs) && addr < TASK_SIZE && unlikely(!(regs->status & SR_SUM)))
> 
> Please avoid the overly long line.
OK, I'll modify it in v2. Thanks for your review.