Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4263109pxu; Mon, 30 Nov 2020 23:58:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJx80res1N/60Kodqk3VqKg+6ICgED1KqLn4rRcG6N5WevWwrA3m1jO0R2bgLsR/PcJApC/W X-Received: by 2002:a17:906:4809:: with SMTP id w9mr1820716ejq.139.1606809507569; Mon, 30 Nov 2020 23:58:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606809507; cv=none; d=google.com; s=arc-20160816; b=qvhFnP3bzjJbat5TgOP0PBRqmEjqLjvSkblQXpWqTu8CMUazqGzKBscCre+X+GRw9F 9fVobkPOBHA1cS3nN6BdUb6jOt6C1KEpYSRQdjFAgOZVfbRyPGulzYlO1YvGQ9znXOOY WLWvnmV8rAOxfwP0Pdq5EjUPToPY+yPDolJb0sVvCsUfLlFFiiHLLGxYSclcMKIxbvdB eF8mVSHdcnQvE9LUIxtKnI9aT7c4+dX/eh6UeeViUzM1YwtfSJVesY56nJRlv2/FkfUY pRGCRNEzBK/t42oVbvO6UqVZ2H/ZT3QnpJyg7AOkEDnAwFH+pt1xUdGbOL95fadL70J8 KceQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=uNMNU/yR47TiwpyMtUifHOozYUyNgo1UzfGJEzhmW9k=; b=RRzGv88UaITepWo31Hy9xQ6mLJ0j0DD7kq51DZj8ujO5AAqNS9PbkxTCAdEeKPVmkc w2Ao87RNVOEtvSuPfu9ck+U43wyq9qNpErh5XwJeVx2nZT1176sCIL+vOH0gsevIhCuv bo1mmbxDOWu2MBQnPiKz7Ww9+X4oLfUnUE0VQPg0WKBiJ6+FzoJpIcmSbIFarCxfQYU6 e+2gC4DaLIglGjlIoO5gXWONEYWptfgBWX/cUkrPnKKS6sM3/sw0A/rxkT1QYiZvlTWG HZ3Q3UJ7gf/qP6Ygkn6zydMVngo21f4ASUfAX3TefjwM4psp20B3rOSAryRMYT7USdMH PXRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs-ru.20150623.gappssmtp.com header.s=20150623 header.b=CB0jODU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x15si462274ejf.349.2020.11.30.23.58.04; Mon, 30 Nov 2020 23:58:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs-ru.20150623.gappssmtp.com header.s=20150623 header.b=CB0jODU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727641AbgLAH43 (ORCPT + 99 others); Tue, 1 Dec 2020 02:56:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbgLAH42 (ORCPT ); Tue, 1 Dec 2020 02:56:28 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89CF4C0613D3 for ; Mon, 30 Nov 2020 23:55:48 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id f17so724575pge.6 for ; Mon, 30 Nov 2020 23:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uNMNU/yR47TiwpyMtUifHOozYUyNgo1UzfGJEzhmW9k=; b=CB0jODU0/X56pw2oJsFUt6jJV5fiwsbihQXNLTqYoqKK9zsQquow9XiEwae75fqk// thkjRXp/wnG8a7e4M4fioFixA8ST4OCZHY2e4MinYLe8PB+TQT1Z0V3I1XgBn9dLGjm0 o43IvAkFtUDo1ukszYVYq7Tbka4BOXSgvgO+et5FXNwsLAW2DuWH7A0dCwEsEL2KFh3N Wi990yB2rUTPEFZVqtipgYgWHAuG24f+t7hbzTkGQ3ftgnrLtWWtCqyfNl4/4Ta+732N e10h3nRmwLtBIYFJ9JWtAWTtxjvTCx7SnlcBSGwFd159CUNA+hPnI46J/eekWALVeDx5 +8jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uNMNU/yR47TiwpyMtUifHOozYUyNgo1UzfGJEzhmW9k=; b=tE/G3aTSzjWhGaZQpGbADKwYaypOPyVvGJZsRVVbjmGXV3bZM8T44FXe2VjRbdqHdv SLcISSpXcvwpGGCLUpd9BTOrlP8QUIyATwY/UPj4u0Od716I0nwT+NzmbS1576uouNep na+pcidVy1Sc6K3xMhmrgypv3c4UqYz/fkb6AaEyeiWTp+BOQxFruVyHoSXcFczc6qgK BakMNCGFkEWcc0eJ6/XWPnz2Lw4eapz+98l5loJGYMmfG0Px4peF0kUBeSujKkUrTJPr VAOfrkeSLflBxyvPSWd74FVoASiWe2nrDP+0+9XzXgMbRZI//H3pflp3QLjQqsZIA/Hj 5H2Q== X-Gm-Message-State: AOAM530bWpYcTBsCor4/A5NQtI/PpWCP/EpFOKGNeJAf0WaApSSsiRo0 rXki3jurToyoPFYjQ8mhfXPQaxvXybr0rg== X-Received: by 2002:a63:4648:: with SMTP id v8mr1291868pgk.248.1606809347720; Mon, 30 Nov 2020 23:55:47 -0800 (PST) Received: from [192.168.10.23] (124-171-134-245.dyn.iinet.net.au. [124.171.134.245]) by smtp.gmail.com with UTF8SMTPSA id y21sm1330257pfr.90.2020.11.30.23.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 23:55:47 -0800 (PST) Subject: Re: [PATCH kernel] fs/io_ring: Fix lockdep warnings To: Pavel Begunkov , io-uring@vger.kernel.org Cc: lexander Viro , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201130020028.106198-1-aik@ozlabs.ru> <44057e4a-9dd0-ddfa-70fd-8f6287de4e2d@gmail.com> From: Alexey Kardashevskiy Message-ID: <8616fff3-8a89-8316-3920-b33fb7db235c@ozlabs.ru> Date: Tue, 1 Dec 2020 18:55:41 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <44057e4a-9dd0-ddfa-70fd-8f6287de4e2d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2020 03:34, Pavel Begunkov wrote: > On 30/11/2020 02:00, Alexey Kardashevskiy wrote: >> There are a few potential deadlocks reported by lockdep and triggered by >> syzkaller (a syscall fuzzer). These are reported as timer interrupts can >> execute softirq handlers and if we were executing certain bits of io_ring, >> a deadlock can occur. This fixes those bits by disabling soft interrupts. > > Jens already fixed that, thanks > > https://lore.kernel.org/io-uring/948d2d3b-5f36-034d-28e6-7490343a5b59@kernel.dk/T/#t Oh good! I assumed it must be fixed somewhere but could not find it quickly in the lists. > FYI, your email got into spam. Not good :-/ Wonder why... Can you please forward my mail in attachment for debugging (there should be nothing private, I guess)? spf should be alright, not sure what else I can do. Thanks, -- Alexey