Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4288251pxu; Tue, 1 Dec 2020 00:50:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1pQc/MshzWjqOAa+Q7RErqPAWfbB6V5e0x2EK2+/ryqhZjex3OJT+6QV6GlEfadAOKOKp X-Received: by 2002:a17:906:a9a:: with SMTP id y26mr1956975ejf.240.1606812643195; Tue, 01 Dec 2020 00:50:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606812643; cv=none; d=google.com; s=arc-20160816; b=DmKVl+LVUgXXZsdZE98/tF+iaLP6MfieS7oGmE1jzQVrecxGDfwXF7k9MVjKr8X2vq C3fLgrWDm7/km48E2jxkNigFxoAIA/V2GIhS27bNUloxG/TjMn9lraxZCprW+fyBtKsn gGS97Hpo5IRdXSDzkIRu4G+eQVFoBBqvGfCH9EMdZs6rTfGVS6ZSUDA7rv3m7/FbjIA7 7B/9uvPRdkrSMZlnJLpJMjlPCSeUoV7vn3Gu3mU5kYcznIjmE0GFqOgu00H0xps2QAf0 XsQ3pB6ao+zfUzSIWfGqL972M6ZBqDqoEAWZGuOKWZ1Jc2aENitWvG8NhoxIJF2t0hV7 D/yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=xMmzKAWtBwcYte1FvxTTPOwDmvsf8bZYUpa/4c/EpMY=; b=lpKVS+cZFFAi4OgaQWcIEglmA+p8QKHe1qW7p294KIhQuBzQsPc2lS8ausDNPCZ+3k XRU8pxpib1E/dinXgeHkui8SDADTSCEFC3/CG0kYXw1eTHPcwZMWOqKBs9QAYZt8DfFz qyRt4W7JWtEYVpKMsG6xhpe8vTDFmPB86i2L3ZrrobFAfU5GL3dwZljXjCGJbPzwbo6Z ruYLRf+VGqqI9QBnRDpZgas8ZAfQex9TfAj93kEvIUAgh4NJaUkxXkQdL8FSxVccQT90 NwbDyyeNa0Sj6gJHPLLATlzfWyPA3gg2RazMhVL9CCLHuUiMN5PrVNJ5BU229XmRFghD ASng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si691302edj.278.2020.12.01.00.50.18; Tue, 01 Dec 2020 00:50:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728912AbgLAIrl (ORCPT + 99 others); Tue, 1 Dec 2020 03:47:41 -0500 Received: from correo.us.es ([193.147.175.20]:51318 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727499AbgLAIrk (ORCPT ); Tue, 1 Dec 2020 03:47:40 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id B4BEB1F0D0C for ; Tue, 1 Dec 2020 09:46:57 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9F5FD11C374 for ; Tue, 1 Dec 2020 09:46:57 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 9E17611C371; Tue, 1 Dec 2020 09:46:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,URIBL_BLOCKED,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5D92C11C368; Tue, 1 Dec 2020 09:46:55 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 01 Dec 2020 09:46:55 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 4145B4265A5A; Tue, 1 Dec 2020 09:46:55 +0100 (CET) Date: Tue, 1 Dec 2020 09:46:55 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: xiakaixu1987@gmail.com Cc: kadlec@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] netfilter: Remove unnecessary conversion to bool Message-ID: <20201201084655.GA26468@salvia> References: <1604650813-1132-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1604650813-1132-1-git-send-email-kaixuxia@tencent.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 04:20:13PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > Here we could use the '!=' expression to fix the following coccicheck > warning: > > ./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here Applied.