Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [BUG] SPI broken for SPI based panel drivers
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=us-ascii
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <CAGngYiXgc_m2A7Wihxuhzm-u4qH-JZgxHjke653zvyT45jMU7Q@mail.gmail.com>
Date:   Tue, 1 Dec 2020 09:59:43 +0100
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        kernel list <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4AC29229-9542-4E77-B993-217E29C7E209@goldelico.com>
References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> <CAGngYiXgc_m2A7Wihxuhzm-u4qH-JZgxHjke653zvyT45jMU7Q@mail.gmail.com>
To:     Sven Van Asbroeck <thesven73@gmail.com>
Precedence: bulk

Hi Sven,

> Am 30.11.2020 um 21:13 schrieb Sven Van Asbroeck =
<thesven73@gmail.com>:
>=20
> Hi Nikolaus, thank you for reaching out !
>=20
> On Mon, Nov 30, 2020 at 2:06 PM H. Nikolaus Schaller =
<hns@goldelico.com> wrote:
>>=20
>> But reverting your patch brings back the display. So it appears as if =
it does not
>> fix a breakage, rather breaks a previously working setup.
>=20
> The patch in question fixes an important breakage: before the patch, =
literally
> hundreds of SPI drivers no longer worked - only if the SPI bus master
> driver was using gpio descriptors.
>=20
> We knew that there was a chance that our fix would break something =
else.
> But hopefully "it fixes more than it breaks"

Then it should not have been applied to mainline but fully worked out =
and tested.

>=20
>>=20
>> What should we do?
>>=20
>=20
> Can you try the following patch ?

Unfortunately it doesn't seem to fix it. And combined with the second =
proposed fix also not.

BR and thanks,
Nikolaus

my combined change:

diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 7ceb0ba27b755c..ec2da62716a279 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -208,8 +208,8 @@ static void spi_gpio_chipselect(struct spi_device =
*spi, int is_active)
        if (spi_gpio->cs_gpios) {
                struct gpio_desc *cs =3D =
spi_gpio->cs_gpios[spi->chip_select];
=20
-               /* SPI chip selects are normally active-low */
-               gpiod_set_value_cansleep(cs, (spi->mode & SPI_CS_HIGH) ? =
is_active : !is_active);
+               /* SPI chip select polarity handled by gpiolib*/
+               gpiod_set_value_cansleep(cs, is_active);
        }
 }
=20
@@ -226,8 +226,7 @@ static int spi_gpio_setup(struct spi_device *spi)
        if (spi_gpio->cs_gpios) {
                cs =3D spi_gpio->cs_gpios[spi->chip_select];
                if (!spi->controller_state && cs)
-                       status =3D gpiod_direction_output(cs,
-                                                 !(spi->mode & =
SPI_CS_HIGH));
+                       status =3D gpiod_direction_output(cs, false);
        }
=20
        if (!status)