Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4307454pxu; Tue, 1 Dec 2020 01:29:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwdPD/xOABLuTD4G1w+9FKz29BI8twV5mVfPO1W2rC4uY5d7Yx6cS+rAIEo7VmoluUv3f5D X-Received: by 2002:a17:906:a197:: with SMTP id s23mr2099483ejy.463.1606814963209; Tue, 01 Dec 2020 01:29:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606814963; cv=none; d=google.com; s=arc-20160816; b=bklvV9AdBz904lkC7pZ+56/cEt2JDk+MNeLfu7w35YoDx2JspfbLvmEjFodUWeHHpr RZkMwRSHs83ltbdMol+mZJvTscJBHIRxKcZsbtvSvjOT9NFQo+biSbaTFs1m8xSJ8HD8 QPa8aWPULhtDPy+ZeWMUm/3bqLC/6QjVaXY+wCuYwxJZj4/HX9yH+UYruxn1mCg48qT6 +obPKx1Nk2f9YEPnGBnp7MbrPbLVjfD4vClEPbAl+pWrdILCzA7UJI4Sy21PbBmmAwax FkuVuGUeRKxdWJyhDg0cPUdFtit7dx1LPRdr9PGOIfob9p/y3uin9zy6GJ81tYqO1eBW dwog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CCiEtMpnUQwhc3lUWtQmzip0nqrSAVxx1JhN72ZCOSU=; b=0ZtfV+mIAQ/3hR+pD9tr7xjo0g6VF5s6gnp/hsoPj4E6zHFzBiE3sm/4AsViNQ8U8e 9ZorEXTIrtn7dhhaJANwN+zuWqAWSURnT2Fb/k0dbzRDW3spa/+mMyLiJP6DAJpKldHN 6lA6/IqXD1n/i0S3+2zyilx9VrZWppRn+kNlMwbIQfROqC40ETMt3pXMDXanC8l+yu6p Se/tpgoCSd4IE8A2ydvFpwGxRHTv7gTOPnabIoGxiVQEEugGKLaSqW57sQdbskAvkYau xNsoD4K7waoDntOq/A2A+OOAxnUTaE+HdWCQd/JHb1zkLpdTQ2Wxs66wVZ1AQBwcKO+Z GoXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si329136edx.28.2020.12.01.01.29.00; Tue, 01 Dec 2020 01:29:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390891AbgLAJYy (ORCPT + 99 others); Tue, 1 Dec 2020 04:24:54 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9080 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390844AbgLAJYf (ORCPT ); Tue, 1 Dec 2020 04:24:35 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Clc8n4XBHzLlcD; Tue, 1 Dec 2020 17:23:21 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 1 Dec 2020 17:23:44 +0800 From: Qinglang Miao To: Orson Zhai , Baolin Wang , Chunyan Zhang CC: , , Qinglang Miao Subject: [PATCH 6/8] i2c: sprd: fix reference leak when pm_runtime_get_sync fails Date: Tue, 1 Dec 2020 17:31:44 +0800 Message-ID: <20201201093144.113225-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201201092924.112461-1-miaoqinglang@huawei.com> References: <20201201092924.112461-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PM reference count is not expected to be incremented on return in sprd_i2c_master_xfer() and sprd_i2c_remove(). However, pm_runtime_get_sync will increment the PM reference count even failed. Forgetting to putting operation will result in a reference leak here. Replace it with pm_runtime_resume_and_get to keep usage counter balanced. Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/i2c/busses/i2c-sprd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c index 19cda6742..103b1a852 100644 --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -284,7 +284,7 @@ static int sprd_i2c_master_xfer(struct i2c_adapter *i2c_adap, struct sprd_i2c *i2c_dev = i2c_adap->algo_data; int im, ret; - ret = pm_runtime_get_sync(i2c_dev->dev); + ret = pm_runtime_resume_and_get(i2c_dev->dev); if (ret < 0) return ret; @@ -570,7 +570,7 @@ static int sprd_i2c_remove(struct platform_device *pdev) struct sprd_i2c *i2c_dev = platform_get_drvdata(pdev); int ret; - ret = pm_runtime_get_sync(i2c_dev->dev); + ret = pm_runtime_resume_and_get(i2c_dev->dev); if (ret < 0) return ret; -- 2.23.0