Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103AbWH2HLr (ORCPT ); Tue, 29 Aug 2006 03:11:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932146AbWH2HLq (ORCPT ); Tue, 29 Aug 2006 03:11:46 -0400 Received: from brick.kernel.dk ([62.242.22.158]:2370 "EHLO kernel.dk") by vger.kernel.org with ESMTP id S932103AbWH2HLq (ORCPT ); Tue, 29 Aug 2006 03:11:46 -0400 Date: Tue, 29 Aug 2006 09:14:29 +0200 From: Jens Axboe To: Oleg Nesterov Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] exit_io_context: don't disable irqs Message-ID: <20060829071429.GQ30609@kernel.dk> References: <20060826203142.GA333@oleg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060826203142.GA333@oleg> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 22 On Sun, Aug 27 2006, Oleg Nesterov wrote: > We don't need to disable irqs to clear current->io_context, it is > protected by ->alloc_lock. Even IF it was possible to submit I/O from > IRQ on behalf of current this irq_disable() can't help: > current_io_context() will re-instantiate ->io_context after > irq_enable(). > > We don't need task_lock() or local_irq_disable() to clear ioc->task. > This can't prevent other CPUs from playing with our io_context anyway. > > Signed-off-by: Oleg Nesterov Applied, thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/