Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1606827507.git.agx@sigxcpu.org> <ee2df27df04e6ff01d15255665458be1000dcfa8.1606827507.git.agx@sigxcpu.org>
In-Reply-To: <ee2df27df04e6ff01d15255665458be1000dcfa8.1606827507.git.agx@sigxcpu.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 1 Dec 2020 15:52:40 +0200
Message-ID: <CAHp75VdwnGD+39AHusGvSKcnOZs7q_AfXniTBaA+J=yMqL4_nw@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] usb: typec: tps6598x: Export some power supply properties
To:     =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Dec 1, 2020 at 2:59 PM Guido G=C3=BCnther <agx@sigxcpu.org> wrote:
> This allows downstream supplies and userspace to detect
> whether external power is supplied.

...

> +static int devm_tps6598_psy_register(struct tps6598x *tps)
> +{
> +       struct power_supply_config psy_cfg =3D {};
> +       const char *port_dev_name =3D dev_name(tps->dev);

> +       size_t psy_name_len =3D strlen(tps6598x_psy_name_prefix) +
> +                                    strlen(port_dev_name) + 1;

I'm so sorry by not noticing this one...

> +       char *psy_name;
> +
> +       psy_cfg.drv_data =3D tps;
> +       psy_cfg.fwnode =3D dev_fwnode(tps->dev);
> +       psy_name =3D devm_kzalloc(tps->dev, psy_name_len, GFP_KERNEL);
> +       if (!psy_name)
> +               return -ENOMEM;
> +
> +       snprintf(psy_name, psy_name_len, "%s%s", tps6598x_psy_name_prefix=
,
> +                port_dev_name);

...followed by this.

Please, use devm_kasprintf() instead.

--=20
With Best Regards,
Andy Shevchenko