Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1606827507.git.agx@sigxcpu.org>
In-Reply-To: <cover.1606827507.git.agx@sigxcpu.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 1 Dec 2020 15:55:18 +0200
Message-ID: <CAHp75Vfws_WMDxxpCpB1zSgbWucYx7-qeev6=mKE+znXSSPWSA@mail.gmail.com>
Subject: Re: [PATCH v4 0/2] usb: typec: tps6598x: Export some power supply properties
To:     =?UTF-8?Q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Dec 1, 2020 at 2:59 PM Guido G=C3=BCnther <agx@sigxcpu.org> wrote:
> This allows downstream supplies and userspace to detect whether external =
power
> is supplied.
>
> The Librem 5 has the tp65982 in front of bq25980 charge controller.  Sinc=
e that
> is capable of sinking and sourcing power the online property helps to dec=
ide
> what to do. It also makes upower happy.
>
> There will be follow up patches providing more properties but these need =
some
> more time to cook and i wanted to check if this is the right way to go?

From my perspective the patches are okay (after addressing one more
comment), FWIW
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> changes from v3
>   - As per review comments from Andy Shevchenko
>     https://lore.kernel.org/linux-usb/CAHp75VeLZtm85Y=3D3QMkPGb332wn05-zr=
-_mrrwXvnqLhazR1Gg@mail.gmail.com/
>     - Use positive conditionals
>   - Add reviewed by from Heikki Krogerus
>     https://lore.kernel.org/linux-usb/20201130102720.GA2911464@kuha.fi.in=
tel.com/T/#u
>     https://lore.kernel.org/linux-usb/20201130102942.GB2911464@kuha.fi.in=
tel.com/T/#u
>   - Fix typc vs typec typo in commit message
>
> changes from v2
>   - As per kernel test robot
>     https://lore.kernel.org/linux-usb/202011271005.zJVawX74-lkp@intel.com=
/
>     - Flip USB_ROLE_SWITCH and REGMAP_I2C from 'depends on' to 'select'
>       This matches tcpm and avoids a config symbol recursion which went
>       unnoticed on my arm64 build but trips up x86_64.
>
> changes from v1
>   - As per review comments from Heikki Krogerus
>     https://lore.kernel.org/linux-usb/20201126123552.GP1008337@kuha.fi.in=
tel.com/
>     - select POWER_SUPPLY
>     - use POWER_SUPPLY_USB_TYPE_PD when a PD contract got negotiated
>
> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,Greg Kroah-Hartman =
<gregkh@linuxfoundation.org>,linux-usb@vger.kernel.org,linux-kernel@vger.ke=
rnel.org,Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Guido G=C3=BCnther (2):
>   usb: typec: tps6598x: Select USB_ROLE_SWITCH and REGMAP_I2C
>   usb: typec: tps6598x: Export some power supply properties
>
>  drivers/usb/typec/Kconfig    |   5 +-
>  drivers/usb/typec/tps6598x.c | 105 +++++++++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+), 2 deletions(-)
>
> --
> 2.29.2
>


--=20
With Best Regards,
Andy Shevchenko