Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp65083pxu; Tue, 1 Dec 2020 06:16:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlZQ4qTSBDq53KvDyNnyt+A58QnikCCLGFiLOjFSedE47Ue3TZea2P/44HqTs2HMRuURsk X-Received: by 2002:a17:906:f753:: with SMTP id jp19mr3218696ejb.280.1606832207141; Tue, 01 Dec 2020 06:16:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606832207; cv=none; d=google.com; s=arc-20160816; b=x0MQrMLJjFp+ALZDf1A33559qoRI0aX0EyKyOvrf+rBADd4CJLJ7P6dp7im9GngR+6 pbfVwZD6BbmDajQKvt3qX3rXrsJ1uITTnX9pUaY0+X33sN4WQo93P1wfMZU4fSrjtiih F4RaSaxV7mWk8nfYwI/LIkDXrBo6mc4FhNfI+Yg8B81mcbRn6Y9F3lJWHCP0bTw1aOOU X7VmaNquMjfw/KnAYtCkoGwaqTvXV3WyeCf7M4UnNzlMDgDGTrxlOG7xzcRY0KwWcvU3 x5ZVXcuPTu7gvZbpXjNArEH1XtDCSQ5EIdgWkcPhjBfd8G16Fy05KkzmmnSRjrNrz0hT 4h+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4ehqe7Y++cS0wt3gaymi/r3HazRaNqrXWmoutWXgkJI=; b=HY12g0aPNMCBaEybmH0KI0mbffbxo9uGfshdyeyuMkjaaAzdM4VHD0Tx4DOrMueQbw HoYtQscGxyZXq9w5vu2VTFZhVw9VbeWqWLWHxTggFbtrya6uY8RsFyd/TNldvl9z3w8v Om3qLICn+kyYN0mQEpMHN175TfVVjZvBnxU64LEWQrK7V0hquLbNqlI6rZzfK4alZtok jSM/mMu6/BADUEocWyUdhjT/BQ9B80xqqlBGO5jynfrIYt5buAo208OlRi8qa1LW673q 6oooZ3y80XsSlepZBHu4tDhazSiX4mYgcBe/XOZ+YzEFHp2mzi+1u9ilCZ2v8NrsmrXJ hh1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lZtqI0O0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si1018316eje.644.2020.12.01.06.16.23; Tue, 01 Dec 2020 06:16:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=lZtqI0O0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730272AbgLAOON (ORCPT + 99 others); Tue, 1 Dec 2020 09:14:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729321AbgLAOOM (ORCPT ); Tue, 1 Dec 2020 09:14:12 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03F5C0613D4 for ; Tue, 1 Dec 2020 06:13:32 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id t4so2807873wrr.12 for ; Tue, 01 Dec 2020 06:13:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4ehqe7Y++cS0wt3gaymi/r3HazRaNqrXWmoutWXgkJI=; b=lZtqI0O05N1Z6dBLwLIaL34QXzkEGIU49CpWF5bKywPYvc+NsWlLRJB0jBInC90Mt3 89664T8lO6L0YFi13mP2WcsaAhioSBSD4FWBbi6qqWT3STAgmu93CNaVR6LGQ3FqmcPI YLyBVZrr7mD1csA7NvKqYE2HQKEMxKuA8xu5QlXB/KwMoLnF+t8zYN+h4dpgHCqap7QC 1EzNcO0dt3YFIHsnoNQBnnnjulsdkJlLYlTi0LR3pTX8ULCGm90EWmy1PEzaMwdvt9Pu 2+ZN8BuknXL4/cDhHQ4TJaXyyKwF6IzTh0BdqogMaaBuEIYhwCzlpyXK+4Ma4CeDjgWI OwIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4ehqe7Y++cS0wt3gaymi/r3HazRaNqrXWmoutWXgkJI=; b=Af6YQepPbOMn2S/6A973Nx7JKOJS1oUBvM75QOZja6YMPiGR3vS+1x6TM4wX1U3EhE h90pDhBxHYUtzIGNyYEiMtw4TvZi89tuTTGSwdd0+4JwCtK1zY8dtH0kb1uj5qU2hTHT OVwSoFM3sUuncwyqqf2Y/B+hdqijR85IhvjLAqY1aKWb/RcHzx+TwYnMGppGYv3dn1a7 8GgM0Ur0iUAiWU4LhDLZLGs31FWWyxxd8rGDuXeS4gHf6Rsa+PHYto15tryP9yByeJkn joXdyHQ+raRB+HkX3cXtfbBq7XxGKH+2vHYVtDzU7GlZZ8nH508MpVMdHhMWlv1itPGk N8mw== X-Gm-Message-State: AOAM533cLgjw4dZ0YBmrWMHSIXKRWEx44Rfa35etQW5IG3MMR7eD7+g8 uOGEv2kmmX0rMtQ5zc5IEN1PdA== X-Received: by 2002:a05:6000:347:: with SMTP id e7mr4104757wre.35.1606832011144; Tue, 01 Dec 2020 06:13:31 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id k16sm3390851wrl.65.2020.12.01.06.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 06:13:30 -0800 (PST) Date: Tue, 1 Dec 2020 14:13:27 +0000 From: Quentin Perret To: Masahiro Yamada Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Greg Kroah-Hartman , "Cc: Android Kernel" Subject: Re: [PATCH] modpost: Make static exports fatal Message-ID: <20201201141327.GA1914005@google.com> References: <20201124182420.2202514-1-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 Dec 2020 at 23:00:37 (+0900), Masahiro Yamada wrote: > I am not a big fan of (ab)using fatal() for this case. > > Please consider using error() once > the following is queued up. > > https://patchwork.kernel.org/project/linux-kbuild/patch/20201201103418.675850-2-masahiroy@kernel.org/ Yes, much nicer, thanks for that series. I'll post a v2 shortly. Thanks, Quentin