Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: VS65tg1XiBUXXQAOtREmWMR/K8JuayT9PwgY+D/0EbIHTG23yq8mWfq+K+OAGekzZ0X6zTa8Ky
 vHlNzu7d8DTA==
IronPort-SDR: oIr6baotrnbYYJYjUUouOdPFczSD6BQ7xNIDT5/BMzoIBBLWpUDWzrQ/cEeYCBsul6C4iEh2an
 uMJCTHTYd4qA==
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Yejune Deng <yejune.deng@gmail.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>
CC:     "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband: i40iw: replace atomic_add_return()
Thread-Topic: [PATCH] infiniband: i40iw: replace atomic_add_return()
Thread-Index: AQHWxvZEXNWJ2mNFXUOrhojqokPY6qniTm7g
Date:   Tue, 1 Dec 2020 14:42:25 +0000
Message-ID: <b578b692d2ec4f598be584b809aed400@intel.com>
References: <1606726376-7675-1-git-send-email-yejune.deng@gmail.com>
In-Reply-To: <1606726376-7675-1-git-send-email-yejune.deng@gmail.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

> Subject: [PATCH] infiniband: i40iw: replace atomic_add_return()
> 
> atomic_inc_return() is a little neater
> 
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
>  drivers/infiniband/hw/i40iw/i40iw_cm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c
> b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> index 3053c345..26e92ae 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_cm.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c
> @@ -2426,7 +2426,7 @@ static void i40iw_handle_rst_pkt(struct i40iw_cm_node
> *cm_node,
>  		}
>  		break;
>  	case I40IW_CM_STATE_MPAREQ_RCVD:
> -		atomic_add_return(1, &cm_node->passive_state);
> +		atomic_inc_return(&cm_node->passive_state);

Just an atomic_inc would suffice here.

>  		break;
>  	case I40IW_CM_STATE_ESTABLISHED:
>  	case I40IW_CM_STATE_SYN_RCVD:
> @@ -3020,7 +3020,7 @@ static int i40iw_cm_reject(struct i40iw_cm_node
> *cm_node, const void *pdata, u8
>  	i40iw_cleanup_retrans_entry(cm_node);
> 
>  	if (!loopback) {
> -		passive_state = atomic_add_return(1, &cm_node->passive_state);
> +		passive_state = atomic_inc_return(&cm_node->passive_state);

Fine with it as its consistent across i40iw. But aren't there many more instances of this across the tree?
Isn't this a choice best left to the developer?