Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp94356pxu; Tue, 1 Dec 2020 06:56:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzl0vdx/cvHkjs3quyxgxvtFPaefbz9a2ADry12/OLyV1QsytH7XTvHTRBUYzs5UPJV4UqY X-Received: by 2002:a17:906:26c6:: with SMTP id u6mr3273372ejc.349.1606834603933; Tue, 01 Dec 2020 06:56:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606834603; cv=none; d=google.com; s=arc-20160816; b=jbBKbeOe/L+grZE8q271jpdTwh9eZg1NHDpIuGTpPY19bANvRWuroWyiaMuRzjPVER CJs0Ej6G0D1h1EfF1ewlrEDgVkhKSbhHNXqnTPVJAOBb2REH1h/B0FQtZFAce1qYOtXM Yf+iOsCUMOvzQLVf0wdOjTiT2cVe+6Lq2O84Yv5jcDME8AXcoPiMbhrcNBLv1XvjIxFt F/EGSBc/R9Cpm/vMg0jd0fHptSeEraJMaj5UBpM3u3T1/BTIVKnobmGfrrkjcASOrEwV Xjgl0+pAWrHgeW4Svc/wYaqwin7XT6/KgNiWO+tEolsCWUJMTZ/8kOuyq8IHu2nzcaiA 8sMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=55sCzQdwTnWWY4frFoH/T/BSKgGKnPew/6aq6eljiTo=; b=MnkjAME2/6DOrgKBzKQJkZDbcpZi0MUcwR5wu2EQ0b7d9gXlkBIM9D52/JVRM7mpD2 Q02UzAK7pgShVBMhxeUPh1BU7yrrbDzpJuZj/cvKunE5K8T0UqS9hrxdQe3l8rdBQMnD u6CECrllyhCoKr9iQD6vhKIId2CgoPRfvn2/XdaurRBgVGFR6Tj2YB1NYKVTHGP0OUH7 axy//PHY7v3W+dXl3fNE2a6LvXmUH+jF1SMq+lMQx1yIburgYH1u/jsGdMuPvfG4b4XT IcCWE5EgeT5tVW77L8ojKYigqp7whO7j6FAUyXMhiHUEVbh93op0DK1aEk3LnwYqcE0+ ytGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Od7Oq8i5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lh17si39848ejb.328.2020.12.01.06.56.20; Tue, 01 Dec 2020 06:56:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Od7Oq8i5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391487AbgLAOwH (ORCPT + 99 others); Tue, 1 Dec 2020 09:52:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388491AbgLAOwH (ORCPT ); Tue, 1 Dec 2020 09:52:07 -0500 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 087F5C0613CF for ; Tue, 1 Dec 2020 06:51:27 -0800 (PST) Received: by mail-qk1-x744.google.com with SMTP id 1so1472502qka.0 for ; Tue, 01 Dec 2020 06:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=55sCzQdwTnWWY4frFoH/T/BSKgGKnPew/6aq6eljiTo=; b=Od7Oq8i5EKOt7lyAPLohe/T+qZWO41dmeqZhqZpqtDgfvunVjdg9tf32XLjJenj8L+ JGidx639XPF8hqU42hKavQY/o0ww8LWaxLXeStBRoE5igoG8X9kxoORory35BiCYr0E9 HzsGUGiqSTL1ts87Bl3ZH1DxxvuqoMl1tWsJ7EuEzbUtwafzKk0fS+JCI3C9x5JMkgFl LcOoRC5QQT2Vi2QFULdi/0FU32TizK504jXS8wi2Dtd7rZI3SGHSEPXMul3KJgenD9SV q8gQnWlGGaRf4lazzxswYs7WeQYK50tXi0qt5aobSwa6iH5VsOgJtcHrVMLessAf+PNy wf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=55sCzQdwTnWWY4frFoH/T/BSKgGKnPew/6aq6eljiTo=; b=AEDfugba93tFltDLGRdKsuAJFB//+WpLDuT1XvHVgz/TdzMKMeH91w+r3VZ5h2TGSy f3xd6LQ3lbyw1Kk+JiK+z1qx7kQxFeJIazSDljmyJRnXIxrJin0HudzSd91BfsdqIgFP wahII0wSiq82uUizGDZ77Pkf5g7rG3aeAt+15/arFxq/I+6g6Opn0nto5yiJRRNoETWz wV6bxaw3PT1sfQlNm/dxbBWQTpA6Wy2eUHDxTXTWheFZFa+EeP+5HDNA7xUbrbpm4pCD PiBSHwM6xHcM/gdeVI2yXUjslZRKMunTUeW85YZop5axp7iCoGlVKNXo3Um3WfOx70Cw kaSw== X-Gm-Message-State: AOAM530QorSdWORfDkUEuMmxZXNR1FbRapFrlMwBQDi2A0z0ptxaw9R7 M1gMgsPPOl9yTryE1Z7vPi7kSc+6DBCBEakfymy4sA== X-Received: by 2002:a37:7b44:: with SMTP id w65mr3270634qkc.350.1606834285972; Tue, 01 Dec 2020 06:51:25 -0800 (PST) MIME-Version: 1.0 References: <20200924040152.30851-1-walter-zh.wu@mediatek.com> <87h7rfi8pn.fsf@nanos.tec.linutronix.de> <871rg9hawf.fsf@nanos.tec.linutronix.de> In-Reply-To: <871rg9hawf.fsf@nanos.tec.linutronix.de> From: Dmitry Vyukov Date: Tue, 1 Dec 2020 15:51:14 +0100 Message-ID: Subject: Re: [PATCH v4 0/6] kasan: add workqueue and timer stack for generic KASAN To: Thomas Gleixner Cc: Walter Wu , Andrew Morton , John Stultz , Stephen Boyd , Tejun Heo , Lai Jiangshan , Marco Elver , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Matthias Brugger , kasan-dev , Linux-MM , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 3:13 PM Thomas Gleixner wrote: > >> > Syzbot reports many UAF issues for workqueue or timer, see [1] and [2]. > >> > In some of these access/allocation happened in process_one_work(), > >> > we see the free stack is useless in KASAN report, it doesn't help > >> > programmers to solve UAF on workqueue. The same may stand for times. > >> > > >> > This patchset improves KASAN reports by making them to have workqueue > >> > queueing stack and timer stack information. It is useful for programmers > >> > to solve use-after-free or double-free memory issue. > >> > > >> > Generic KASAN also records the last two workqueue and timer stacks and > >> > prints them in KASAN report. It is only suitable for generic KASAN. > > > > Walter, did you mail v5? > > Checking statuses of KASAN issues and this seems to be not in linux-next. > > > >> > [1]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22+process_one_work > >> > [2]https://groups.google.com/g/syzkaller-bugs/search?q=%22use-after-free%22%20expire_timers > >> > >> How are these links useful for people who do not have a gurgle account? > > > > This is a public mailing list archive, so effectively the same way as > > lore links ;) > > Just that it asked me to log in last time. That's why I wrote the > above. Today it does not, odd. Some random permissions settings changes were observed before, so I can believe that.