Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp128714pxu; Tue, 1 Dec 2020 07:39:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwABO66yizwpHzLhH9E9cgk14cpJv45tU5pySdGXnLnLwozV/Q0hrCPCy3d7q3hF9H2T0GX X-Received: by 2002:a17:906:c7d9:: with SMTP id dc25mr3678882ejb.138.1606837152117; Tue, 01 Dec 2020 07:39:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606837152; cv=none; d=google.com; s=arc-20160816; b=YJwX0OYIFswO+aYWmSwGPCFGDbs8XlO5Sl3tYObmlHTOdg+IyDVkYAeZ/QAJU3ftIy xXfuu4XjFlwgV8xNbrpJklMaXs1BBX6nXD7cNsxnfXMQrRtgDl5NaldZd51B1OFSCjX4 6FJ7HLrX7cGyTy2BK4/VBovre7vV7K80sW/cLrJ4ZyspeTiqHHxC4KJ2rp8rocCCnmlG hOO3qDgcrBjMDS8jOF8JZkjqkOy0EsD6VUswRJtSPVW1ZoAdSyXGCVYnwZ8yoGUPv5dP 7YkUrGVUQJgw8bM4ni4fAs6aROp2b+VtcPI6+IqRltInTm2IPOnfdry5g5j1xhSTMVzB sWRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=HfEmRbTUVu5buzmFymRjrzPmVpKwAUdxNZbmsbAARHI=; b=x/CUEE3cyt/RjCaSByCv6OJGYCvRNVwKwCJuJkCq9YUOIpkt/rqhSy4I71ty7JFpIW vg1QN+bx0SX9PuLYqBVrAhPake6BYK++RdrCqBbzXsq8hDyY0robzupC4jd+pq8AXG0t x9IARDG2DEKoohPJTGhB1PmgnDqPs+x5wHSn+ue0cSV7OBWVeXq1xQ7lXhz8ArlbsjmV eqzgKwYU8Q2H0YCTZkTPEw0x9Yxw0rpUGW1sBICX4Hi2S688rJlm7MGthxMLPVoNlC2Z 8MC9fehQcJftbFHE3V88i3EsWbVnq3C63c/oMtmDMvEipAoDhSuUtKnbDlOAEQR6MACL LX9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=zpM6mciO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j11si110721eja.691.2020.12.01.07.38.40; Tue, 01 Dec 2020 07:39:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=zpM6mciO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391563AbgLAPe1 (ORCPT + 99 others); Tue, 1 Dec 2020 10:34:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390298AbgLAPe0 (ORCPT ); Tue, 1 Dec 2020 10:34:26 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 941D8C0613CF for ; Tue, 1 Dec 2020 07:33:40 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id f23so4938541ejt.8 for ; Tue, 01 Dec 2020 07:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HfEmRbTUVu5buzmFymRjrzPmVpKwAUdxNZbmsbAARHI=; b=zpM6mciORqM6FM9fWyXykgzZO3tN82WyO0CznE01WirlCqvzyB+NGE5sturlw191Qx Xq63A6beE6QUlpwGR8Y2YKDluTLb33Ve5fE1Uc28FMlxUg54ywnsX8QPhpf1MHECTtqZ ScroKkCi3TaDc25Jq20JrHOD/xCk6mneZMpeNk/pcThyqwNMh5X5EjN17rbvEZvvOhqO Q+GW6ry+hLHmpavB/uFRWpWIRCSqR5An+CX7Ea1DvPduQXTsImNn/KJfEoH3ZU37N+pP HN9G5K2EnscgljSpnGyrGFRRWTNDf5RxzEi+fuWqxcZrq2vWBCAipkpsHGklZeiyXvcF Qwuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HfEmRbTUVu5buzmFymRjrzPmVpKwAUdxNZbmsbAARHI=; b=TuVW4vj8X/XWvOY2CPFz8wqs3hWLvzBLMXfvfyUqlomC3rtmMc5ICD/4P13wsfnr/t RWruXWiDO8yGA2+w8/yEnTL+0OJTYLV+8qhfwgfoPDXzAezOaoOCdM0gfBXEe2GJZoiL skhsrn1I7KatPMwm8elSIkHS+q2qhFszOMlFqiE2/xy3YoK+UuHMei5KQGs7QGj+cDP2 qXAZM5FquQqrFHC2sXvmTtH425Ntn1a60jcu4CA0cu5LL+CUk6XCRuk/ifv35iK6rezK pijFUx2gkRzQw6ic2uwi8erWOFuKtku3K4kAlmWtzVQLNdBZtwzezw7iAMIjclQRXZwF Pu6g== X-Gm-Message-State: AOAM533Fyv52o5nlsrvWg9Js6OLCWiRT2VVTtNQtBkTULvnOaC5Kj1h0 q77HgzTWnTOLVVBX9wwRntS+XisNSYiOtmLgAxWDRQ== X-Received: by 2002:a17:907:b09:: with SMTP id h9mr3591194ejl.155.1606836819337; Tue, 01 Dec 2020 07:33:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Tue, 1 Dec 2020 16:33:28 +0100 Message-ID: Subject: Re: [RESEND PATCH 3/4] gpio: xilinx: Modify bitmap_set_value() calls To: Syed Nayyar Waris Cc: Andrew Morton , Andy Shevchenko , William Breathitt Gray , Michal Simek , Arnd Bergmann , rrichter@marvell.com, Linus Walleij , Masahiro Yamada , Zhang Rui , Daniel Lezcano , Amit Kucheria , linux-arch@vger.kernel.org, linux-gpio , LKML , arm-soc , linux-pm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 7:46 PM Syed Nayyar Waris wrote: > > Modify the bitmap_set_value() calls. bitmap_set_value() > now takes an extra bitmap width as second argument and the width of > value is now present as the fourth argument. > > Cc: Michal Simek > Signed-off-by: Syed Nayyar Waris > --- > drivers/gpio/gpio-xilinx.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > index ad4ee4145db4..05dae086c4d0 100644 > --- a/drivers/gpio/gpio-xilinx.c > +++ b/drivers/gpio/gpio-xilinx.c > @@ -151,16 +151,16 @@ static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, > spin_lock_irqsave(&chip->gpio_lock[0], flags); > spin_lock(&chip->gpio_lock[1]); > > - bitmap_set_value(old, state[0], 0, width[0]); > - bitmap_set_value(old, state[1], width[0], width[1]); > + bitmap_set_value(old, 64, state[0], width[0], 0); > + bitmap_set_value(old, 64, state[1], width[1], width[0]); > bitmap_replace(new, old, bits, mask, gc->ngpio); > > - bitmap_set_value(old, state[0], 0, 32); > - bitmap_set_value(old, state[1], 32, 32); > + bitmap_set_value(old, 64, state[0], 32, 0); > + bitmap_set_value(old, 64, state[1], 32, 32); > state[0] = bitmap_get_value(new, 0, width[0]); > state[1] = bitmap_get_value(new, width[0], width[1]); > - bitmap_set_value(new, state[0], 0, 32); > - bitmap_set_value(new, state[1], 32, 32); > + bitmap_set_value(new, 64, state[0], 32, 0); > + bitmap_set_value(new, 64, state[1], 32, 32); > bitmap_xor(changed, old, new, 64); > > if (((u32 *)changed)[0]) > -- > 2.29.0 > This series is not bisectable because you modify the interface - breaking existing users - and you only fix them later. Please squash those changes into a single commit. Bartosz