Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp190332pxu; Tue, 1 Dec 2020 08:59:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6RlP+ENvsBWFMKJMxQGBU4bJCPl3pEWH14tNpeSwM2yU7WaF4Aj2dlb+xK38AiOpS6jAT X-Received: by 2002:a17:906:6404:: with SMTP id d4mr3858399ejm.159.1606841960881; Tue, 01 Dec 2020 08:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606841960; cv=none; d=google.com; s=arc-20160816; b=ScmnDAlMCqswIeoR7y9m2Ga9Nyy9ktVImEUdSaBwTMfHKzMY63/UdMjIAjWEzZ+xrn irRznBjWhHsflXGhS6zb+DR45Dm8KUOEisiExQ0TyryUZjLryEAyNiUFza1uoQXGJpN1 mJAGZ7ZJ/WgoLofZAc72BAOtRJAb39Sjs49lFisHL9wMKgQnY+hhEZBcFBaeZzZu7A4n SIxWaCyrelp75roOG2IZ8s4/z7X15r5doHD3/Qj3Rth2JuQD2b7/iMxLD3bu7aJl32s/ g+TZPlDC1Lsdmttwuuacv02gv21uTAntZn3TYzUDv3fJO49RMF5OSoU4c/9goWQX1MI6 rXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zvxLNP0+Dun/ZIW79vOWfWns3V91bn/ACv08wEuiwsY=; b=BuShrIGW5sMDZjy/SBSzfW4kGmccAZpa3yB5SJADKrCU9WBAiFY1/T3S0TAk8vryUc 4tmWHG13oTV87CIq9RlCe+gaG6RsszGHwnN3o/Smb0QpOZoTBulFO/kD3jbc/HGmSngs yR7ebrcQsSncs9rlwiGzeK0JucCwV2qjyLDGE7M/uWU/UYzGXLXCGhScHSD9ZTjRSFpQ BIohKc5lnvA43FFJbs6DKi0BQgES602afkTLuYG/DnSQSACReKCMSrsuJ3swMA+1EWpg EtZpiy/L0G6qthD12u8DyndaPIscuIJp8FI+/gBId8on7zIUWWBnpuiII3XYS9Ehy6JE cI9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OB5agNrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si205357edh.538.2020.12.01.08.58.57; Tue, 01 Dec 2020 08:59:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OB5agNrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728325AbgLAQy4 (ORCPT + 99 others); Tue, 1 Dec 2020 11:54:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387563AbgLAQy4 (ORCPT ); Tue, 1 Dec 2020 11:54:56 -0500 Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D854C0613CF for ; Tue, 1 Dec 2020 08:54:10 -0800 (PST) Received: by mail-ua1-x929.google.com with SMTP id y26so792213uan.5 for ; Tue, 01 Dec 2020 08:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zvxLNP0+Dun/ZIW79vOWfWns3V91bn/ACv08wEuiwsY=; b=OB5agNrIBxaBFXkG2EvBefdM6/P/440YEoaCeCWFPu45dmabzIVmd3UbykBbKrtcYM DcmEcN4xljLcKH4klVHTkl+5bkn4CfgChxkaTmOqNvrYVzSWlLXilCMW92YR3l54jHWd EChgbS79pIEEZuLjkcgHIlKCSPxemjxVnbXUUf8DXLAWEZOowSJMaAZIhrhC5JO7YUjT ocxOUEggpX0GsAw7N3wOORwzTYosM8cTc+a+vqaZ+sVVjDWc4x+6Z1igO7CRcFYLng2i oSA1TIgQJyvcHhhxlqmtmHwW0G9PGWu82jo1J8tg/JCRzWFw2DUVL8gjlk/fItDl1k/a TCrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zvxLNP0+Dun/ZIW79vOWfWns3V91bn/ACv08wEuiwsY=; b=YxZPSo60S3ozz0Crup3zbhijLR+lKo5eKZe0oWNX2lRioIsLNG3GdWOCT55Tbc52kr iqAGmmU/jwZlgJ44YzYW6Bp+/hxViqrif8KRxrj3VDU56tjQ7hfxBOWbgoB+1eSlqXL+ cVMrCGvZoaTUNAhUHMjXtxJ8J+o3klv6BuluJgtXqTlfx+lVQNAQ21KDFqM8ws8UYhUn koaw7wYJ2QclwPUhoRYQehOU7MgoJfyHfK0Fn5o8NtaKnn4lgEObKDck1xl3RcfGHo6j 2THTOK7e+juHY3QBOQi4PTtQfPGiJxGFJ3ZVty2X+u1abeAVw9xcnYYBeJ5lLNVqqd2Q 5O6g== X-Gm-Message-State: AOAM530ZFyQeE8eS2E+5xWfHM+7UrGYj/tfRwnsBjTatAO/RwbnsiE4d KWx66FlHjCSj3tB3bejjQmz+sTxRYAnK+LoyXgTF2MYJ X-Received: by 2002:ab0:1d83:: with SMTP id l3mr3937580uak.41.1606841649476; Tue, 01 Dec 2020 08:54:09 -0800 (PST) MIME-Version: 1.0 References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> <4AC29229-9542-4E77-B993-217E29C7E209@goldelico.com> <20201201121620.GB5239@sirena.org.uk> <6283C16F-549C-4463-BC08-E2C1A1D78B2F@goldelico.com> <9380CE00-9CE6-4E0B-B2E1-1B534F85E47D@goldelico.com> In-Reply-To: <9380CE00-9CE6-4E0B-B2E1-1B534F85E47D@goldelico.com> From: Sven Van Asbroeck Date: Tue, 1 Dec 2020 11:53:58 -0500 Message-ID: Subject: Re: [BUG] SPI broken for SPI based panel drivers To: "H. Nikolaus Schaller" Cc: Linus Walleij , Mark Brown , kernel list , Laurent Pinchart , Discussions about the Letux Kernel , Andreas Kemnade Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikolaus, On Tue, Dec 1, 2020 at 11:43 AM H. Nikolaus Schaller wrote: > > You are right. It is active low. > In that case, we have a very simple solution, just remove the spi-cs-high, and things will work. In case of SPI CS gpios, the current kernel ignores all GPIO_ACTIVE_HIGH/LOW flags, and uses the presence/absence of spi-cs-high instead, to determine active high / active low.