Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next 4/6] net: ipa: add support to code for IPA v4.5
To:     Alex Elder <elder@linaro.org>, <davem@davemloft.net>,
        <kuba@kernel.org>
CC:     <evgreen@chromium.org>, <subashab@codeaurora.org>,
        <cpratapa@codeaurora.org>, <bjorn.andersson@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        linux-tegra <linux-tegra@vger.kernel.org>
References: <20201125204522.5884-1-elder@linaro.org>
 <20201125204522.5884-5-elder@linaro.org>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <5b5d9d40-94d5-5dad-b861-fd9bef8260e2@nvidia.com>
Date:   Tue, 1 Dec 2020 18:11:57 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201125204522.5884-5-elder@linaro.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 25/11/2020 20:45, Alex Elder wrote:
> Update the IPA code to make use of the updated IPA v4.5 register
> definitions.  Generally what this patch does is, if IPA v4.5
> hardware is in use:
>   - Ensure new registers or fields in IPA v4.5 are updated where
>     required
>   - Ensure registers or fields not supported in IPA v4.5 are not
>     examined when read, or are set to 0 when written
> It does this while preserving the existing functionality for IPA
> versions lower than v4.5.
>=20
> The values to program for QSB_MAX_READS and QSB_MAX_WRITES and the
> source and destination resource counts are updated to be correct for
> all versions through v4.5 as well.
>=20
> Note that IPA_RESOURCE_GROUP_SRC_MAX and IPA_RESOURCE_GROUP_DST_MAX
> already reflect that 5 is an acceptable number of resources (which
> IPA v4.5 implements).
>=20
> Signed-off-by: Alex Elder <elder@linaro.org>


This change is generating the following build error on ARM64 ...

In file included from drivers/net/ipa/ipa_main.c:9:0:
In function =E2=80=98u32_encode_bits=E2=80=99,
    inlined from =E2=80=98ipa_hardware_config_qsb.isra.7=E2=80=99 at driver=
s/net/ipa/ipa_main.c:286:6,
    inlined from =E2=80=98ipa_hardware_config=E2=80=99 at drivers/net/ipa/i=
pa_main.c:363:2,
    inlined from =E2=80=98ipa_config.isra.12=E2=80=99 at drivers/net/ipa/ip=
a_main.c:555:2,
    inlined from =E2=80=98ipa_probe=E2=80=99 at drivers/net/ipa/ipa_main.c:=
835:6:
./include/linux/bitfield.h:131:3: error: call to =E2=80=98__field_overflow=
=E2=80=99 declared with attribute error: value doesn't fit into mask
   __field_overflow();     \
   ^~~~~~~~~~~~~~~~~~
./include/linux/bitfield.h:151:2: note: in expansion of macro =E2=80=98____=
MAKE_OP=E2=80=99
  ____MAKE_OP(u##size,u##size,,)
  ^~~~~~~~~~~
./include/linux/bitfield.h:154:1: note: in expansion of macro =E2=80=98__MA=
KE_OP=E2=80=99
 __MAKE_OP(32)
 ^~~~~~~~~

Cheers
Jon

--=20
nvpublic