Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp331086pxu; Tue, 1 Dec 2020 12:20:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJyv1vOrjorVmx6XNd8Ja6yUKRM7OkR2RLH++WxqJzcmV62+jFyCpwjbRu/gamh2wZp5civH X-Received: by 2002:a17:906:b295:: with SMTP id q21mr4915961ejz.178.1606854026162; Tue, 01 Dec 2020 12:20:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606854026; cv=none; d=google.com; s=arc-20160816; b=rnw28pC+ixh+R1EBk+M5rQbVrK0cXAcwoiRkN80vpnXaQ6btIQjJCFd/ThNpEbiTDa QYpE4bGd2kv9oAw4e7KaOBPzkv+wvcMU9JhoNSmlKD6JZTyo01d3xEPvsWg4ICo6IP+D bsxs140zrJT0kElqAoCl9NGME1Jhm0MscbQ3JNYTXrlnHQOZIPTNdsrMZLw1sz0/jFXu w94upFhZcaq70G7XOUTLT+/bnWkfw37XszLgExNxOJfrKZm905kyDKj4FZKE9GWrUy6m fBoSi8WGNw2g+dLjUHygZO68O4smlAUfDlQum7NLzrfhm/hUBb4Wilk3GNd5P+tZZ74C yKiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1ns4HG9DM27lmRcUp9biCqhgyVmAToMpSvVFQa0yBXI=; b=v4uexwPqEFZBl922X62055bOZi/uCUvqEi1crziGq322pXfmHDn12SSYAuNywFKJeR rp/ZN2fiP8iXEyCTtdROdlgSC8jy6L0zkCBntd0mb71p+bfWkmragjhhStoeZSTbkgPR zlpvVxFjv3VaHlK2+ygdlqy0q1LbcPvzJtfMzfVX+hOG3jsw1DO2bi356hfwqeKS/NvO EoaJOcP4BDp61eupW29iwFYCimi45WN3fRCE+nVzfIzIOJu9Uk3QFrZKWlf3pDXXFlnY NZdNNcR7OML+AtTZa9dhOcZrciV/S7iF2Z9Te3QyXFCukeT70CO+Jfi7tfkZv+o/9BR4 QWBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx19si568270ejb.535.2020.12.01.12.19.46; Tue, 01 Dec 2020 12:20:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730559AbgLAUSU (ORCPT + 99 others); Tue, 1 Dec 2020 15:18:20 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37905 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728371AbgLAUSU (ORCPT ); Tue, 1 Dec 2020 15:18:20 -0500 Received: by mail-ed1-f65.google.com with SMTP id y4so5293743edy.5; Tue, 01 Dec 2020 12:18:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1ns4HG9DM27lmRcUp9biCqhgyVmAToMpSvVFQa0yBXI=; b=qt74laS4NpZHcaZcw4vhseCgJbLGXyQYa8DQV9bHbwCtOqezp8iwVVaA5mOe+47IV9 btOm8HmXA7eVMq7RdWkBext2KADK8V3DlHnBv2bvwv7+s9vT+ZaDOwPz+TLAD2VkNKSD P/ZikCFZPZ3G/WVK+9OUJRhtDlr6c7zcs3JI7UsGbRCXnyoeajRDEFUjDL3/fnzxs2Xh Yp7Ps+Fc4GS8ifAbVaM/nrDFTExWx0sfgHeQApFfTirKEdpPKFZOckQSRUElVDoJWrfe q/XGarvLeSsFwqcxYF4SUnrfM7G7bIuMVrknkHRRZjt8Atkz8k5tc9SvEvnYbwEJsWLx bJUw== X-Gm-Message-State: AOAM530cr/wPjNIkJ2PwByzm0JAzH8TiMAshD45fyGPFVkfD89u1PCwb wQjQ1fR5/DhO32QFf+4WIZ0= X-Received: by 2002:aa7:cc19:: with SMTP id q25mr4847401edt.290.1606853857665; Tue, 01 Dec 2020 12:17:37 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id d9sm412152edk.86.2020.12.01.12.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 12:17:36 -0800 (PST) Date: Tue, 1 Dec 2020 22:17:35 +0200 From: Krzysztof Kozlowski To: Bongsu Jeon Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bongsu Jeon Subject: Re: [PATCH v4 net-next 3/4] nfc: s3fwrn5: extract the common phy blocks Message-ID: <20201201201735.GC2435@kozik-lap> References: <1606830628-10236-1-git-send-email-bongsu.jeon@samsung.com> <1606830628-10236-4-git-send-email-bongsu.jeon@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1606830628-10236-4-git-send-email-bongsu.jeon@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2020 at 10:50:27PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/Makefile | 2 +- > drivers/nfc/s3fwrn5/i2c.c | 117 +++++++++++++-------------------------- > drivers/nfc/s3fwrn5/phy_common.c | 63 +++++++++++++++++++++ > drivers/nfc/s3fwrn5/phy_common.h | 36 ++++++++++++ > 4 files changed, 139 insertions(+), 79 deletions(-) > create mode 100644 drivers/nfc/s3fwrn5/phy_common.c > create mode 100644 drivers/nfc/s3fwrn5/phy_common.h > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof