Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] [PATCH] fs: 9p: add generic splice_read file
 operations
In-Reply-To: <20201201153950.GA20545@nautica>
References: <20201201135409.55510-1-toke@redhat.com>
 <20201201145728.GA11144@nautica> <20201201151658.GA13180@nautica>
 <87mtyx1rem.fsf@toke.dk> <20201201153950.GA20545@nautica>
Date:   Tue, 01 Dec 2020 21:37:15 +0100
Message-ID: <87eek91cw4.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Dominique Martinet <asmadeus@codewreck.org> writes:

> Toke H=C3=B8iland-J=C3=B8rgensen wrote on Tue, Dec 01, 2020:
>> > This made me test copy_file_range, and it works with both as well (used
>> > not to)
>> >
>> > interestingly on older kernels this came as default somehow? I have
>> > splice working on 5.4.67 :/ so this broke somewhat recently...
>>=20
>> Huh, no idea; this is my first time digging into filesystem code, I
>> normally do networking and BPF :)
>
> In case anyone else wants to know, this broke in 5.10-rc1 with
> 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
>
> So really a recent regression, good catch :)

Thanks - and what a lucky coincidence that I happened upon this now so
it can be fixed before 5.10-final :)

-Toke