Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp359765pxu; Tue, 1 Dec 2020 13:07:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXuuASDX+2YMuAonwZbwrsZiFaQzkNtnOkabMaRHp9Af+jtIsLHLRFLVYvBOw926UmCluK X-Received: by 2002:aa7:c816:: with SMTP id a22mr4917926edt.373.1606856870497; Tue, 01 Dec 2020 13:07:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606856870; cv=none; d=google.com; s=arc-20160816; b=LmB2qagwvTzgEFwvEWW4iZvmR2jN29RKIuDY70e5loVptMjP06o/wAFc9AONfB4XwZ D/NG9ygz8o/obq71wPW62FzZCvCrLj+b6UMoIFPDoHkvzuVgFjZ3ao1FfwFzEdD1Aria b6gpYTl62SVsTGFioDE7kMZFxZGs+EU7b90h9Oe1SO96xajYZH5rrXlX4oz+jE9Ma+El N5+v9FNFfsK0tWd/bCaDQCWXhDQK7nYsLzjt4E3C20TYgzCDV87gSldlB9FhYHEwBKL6 jlv+Tl/oe78VUTB46aI8iEynPyWPefF93P8vfjcKnic2KC71BxtULqiBg5hNo1K+E6D3 ZMKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=wVPezxXGFXUfwhFYqa6Djcjyd6cYjq8Fl9klsgPVelA=; b=CGlruFtQiowkdyMCMqd6hzJ7ypK/4bi7lOCWkqEiak3VLbYTu5KLCmyLRRIaotq9Ef 4wCnVtE1uxSONGDSV5H0xTcqFZy7rPjjPHv6UuFy/cuS0NMzgfVoaOGor4y7N0V2KwxJ zzmWfIz7rM74Dcis4vbBOPaVq1Jw+68GNX5Sudb7rb9wVfmuZG0+wQnkRz7IksglGkF2 n2epoX2YDh9p/GW1XBEa6vAK/OW7GyRr27HG/0V6N7jU9CIT2t1N4sfaRgYoM9mGFgDv tXGCJ/SrGiCJgrNnUIUQv7iI8HOJQzcFvXwqt2JFuJJkyB8KbOhBuvT4j5TzhGwxYCc0 jwqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LgcYzVlT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g9si643645ejm.641.2020.12.01.13.07.27; Tue, 01 Dec 2020 13:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LgcYzVlT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388433AbgLAVFj (ORCPT + 99 others); Tue, 1 Dec 2020 16:05:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49676 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728009AbgLAVFj (ORCPT ); Tue, 1 Dec 2020 16:05:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606856653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wVPezxXGFXUfwhFYqa6Djcjyd6cYjq8Fl9klsgPVelA=; b=LgcYzVlTwjs5HdW8YTxIKFsRRGOv93HiDnlYmJuHjPQVdS+cjk8iNnGVveu4SodqvDLUe1 QAw06p+C+gq0tx8nWHhUov4sYqjRs6D2DRFHAhPZEyuKzjf+fDTKqI3QpqYwL9FvFuKWgl nlblf2BhBhXI0N6T3tjrw1jBUBPXSnc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-0-5De3DzO4G1pueqNulWww-1; Tue, 01 Dec 2020 16:04:10 -0500 X-MC-Unique: 0-5De3DzO4G1pueqNulWww-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76353185E485; Tue, 1 Dec 2020 21:04:09 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-159.rdu2.redhat.com [10.10.112.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFF6D60854; Tue, 1 Dec 2020 21:04:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <05a0f4fd-7f62-8fbc-378d-886ccd5b3f11@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Eric Sandeen , Miklos Szeredi , Ira Weiny , linux-fsdevel , linux-man , Linux Kernel Mailing List , xfs , Ext4 Developers List , Xiaoli Feng Subject: Re: [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <300455.1606856642.1@warthog.procyon.org.uk> Date: Tue, 01 Dec 2020 21:04:02 +0000 Message-ID: <300456.1606856642@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > And if IS_DAX() is correct, then why shouldn't this just be done in > generic code? Why move it to every individual filesystem? One way of looking at it is that the check is then done for every filesystem - most of which don't support it. Not sure whether that's a big enough problem to worry about. The same is true of the automount test too, I suppose... David