Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Dec 2020 22:26:03 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Michal Simek <michal.simek@xilinx.com>
Cc:     Zou Wei <zou_wei@huawei.com>, rajan.vaja@xilinx.com,
        jolly.shah@xilinx.com, tejas.patel@xilinx.com,
        manish.narani@xilinx.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] firmware: xilinx: Mark pm_api_features_map with
 static keyword
Message-ID: <X8a067jdynVt3Lvg@kroah.com>
References: <1606823513-121578-1-git-send-email-zou_wei@huawei.com>
 <65ea30eb-2595-4af8-09c2-6d352b9be509@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65ea30eb-2595-4af8-09c2-6d352b9be509@xilinx.com>
Precedence: bulk

On Tue, Dec 01, 2020 at 01:03:59PM +0100, Michal Simek wrote:
> 
> 
> On 01. 12. 20 12:51, Zou Wei wrote:
> > Fix the following sparse warning:
> > 
> > drivers/firmware/xilinx/zynqmp.c:32:1: warning: symbol 'pm_api_features_map' was not declared. Should it be static?
> > 
> > Signed-off-by: Zou Wei <zou_wei@huawei.com>
> > ---
> >  drivers/firmware/xilinx/zynqmp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> > index d08ac82..fd95ede 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -29,7 +29,7 @@
> >  #define PM_API_FEATURE_CHECK_MAX_ORDER  7
> >  
> >  static bool feature_check_enabled;
> > -DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
> > +static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
> >  
> >  /**
> >   * struct pm_api_feature_data - PM API Feature data
> > 
> 
> The patch is good but I am missing fixed tag to get it to LTS.

Why is this needed for any stable kernel release?  It's a sparse
warning, no one trips across those in stable kernels...

thanks,

greg k-h