Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Fixes tag needs some work in the block tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Christoph Hellwig <hch@lst.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20201202080254.4e8dbb43@canb.auug.org.au>
 <9ef33d53-a98e-7608-da86-f3cf7b4b6da1@kernel.dk>
 <20201202084452.790e9f16@canb.auug.org.au>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <2ed44adf-9fcf-a1a7-73e8-b6b5aabd8638@kernel.dk>
Date:   Tue, 1 Dec 2020 14:52:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201202084452.790e9f16@canb.auug.org.au>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/1/20 2:44 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Tue, 1 Dec 2020 14:09:24 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 12/1/20 2:02 PM, Stephen Rothwell wrote:
>>>
>>> In commit
>>>
>>>   573cc9d095bc ("blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats")
>>>
>>> Fixes tag
>>>
>>>   Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
>>>
>>> has these problem(s):
>>>
>>>   - SHA1 should be at least 12 digits long
>>>
>>> For the future, this can be fixed by setting core.abbrev to 12 (or more)
>>> or (for git v2.11 or later) just making sure it is not set (or set to
>>> "auto").  
>>
>> It's in Linus's tree, not in -next. The ship has sailed...
> 
> Ummm, 573cc9d095bc is only in your tree as far as I can see ...
> however, I don't really expect these short SHA1 issues to be fixed up
> (as that would require rebasing your tree), just that people will try
> not to do the same in the future.

Hmm yes, but that's because I botched something up. I'll take a look!

-- 
Jens Axboe