Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp391922pxu; Tue, 1 Dec 2020 14:03:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4KIlXAIkvYInmKMHdbR26Dl4IXKThfcOqxLzybENoD35vEitV/Oc42fXQCOnJC2TAFdOO X-Received: by 2002:a17:906:971a:: with SMTP id k26mr5257171ejx.279.1606860202439; Tue, 01 Dec 2020 14:03:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606860202; cv=none; d=google.com; s=arc-20160816; b=b3XdiwXs8JE/Kvci9tcywkDVUcB0t6Lm5nGvpl1r/WkfbVA8JN09UkoRygkGvMRQbJ DIsOoX8Y5LuDDsldCQFcf5WefeGn4iggGi9aJVG2lA/4scSbWgMoQLaUKbNweoP6yZFg usYaVJak1Hqyb7N3bUQ4VLHmUrx3RnvzsAbyo5leKFYKWZoq0XbKAukyvG5PE0bmnTVr 9xFn8PrLfDxF2sKWz52ixo7Rij+Nd7oLpht9tHnX7GvXE0P2pBk4wszmwqDg6ng6BSbq IXvuCkKDXNvCVXPwBMrctWrGjLnfLZmZb+24et2grxLHbtpZq2pJpd+HIbmuaRkxFfMd sLqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kxkjB6Nz8ZK6LGhP0EkOecQD80sPWP9YJ8aS87kUdss=; b=SD7acxc2iARjczUXOGhL3g5rv2NRCTjBpF9AdXRWT1JW+1x6DViRn65XsAahzEbaer p8obhrIV6QrhsmASakE2yZr569iTFPH5k+2Tt0UFMmXndaDIP7XFBV6LdEIYnEMLRXb0 XWE2KAIQRmmcFYowkixZ12AQg0CSDTQ9CtconEvdgKGngewl9ggphvxahmJB95kgA/67 bj55jvzj4msqEezkFVeOgrc0r0MmOOxuxwSjxJ5bmSIRVUOOQna7UT+YRGc8upoxasRE Yef9TAXZIGyHezwWddoTDSjh51XdZLnTb5rt3azt2PxJQb9dONwWDlQzfc15d/602sAl cbeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=U9AboL+V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si765883eja.375.2020.12.01.14.02.59; Tue, 01 Dec 2020 14:03:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=U9AboL+V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391067AbgLAWAF (ORCPT + 99 others); Tue, 1 Dec 2020 17:00:05 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:2390 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391008AbgLAWAE (ORCPT ); Tue, 1 Dec 2020 17:00:04 -0500 Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B1LnrGx027045 for ; Tue, 1 Dec 2020 13:59:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=kxkjB6Nz8ZK6LGhP0EkOecQD80sPWP9YJ8aS87kUdss=; b=U9AboL+VgYl9pGybvHJUbC0H9FDHRzdn8mta+63eWLC3ri/VSuevYMoQBVqQQ/CWsqbn D6F5p5jH3Zy04we5EDj2ZrQP8Iv4dOyjB6yN6EhTYzxtYZSTO3FfIYLrrzuH3u8imc9a amth8Qf1eAeHw1nr8LROWhUDRU+IR6YSajM= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 355vfk0t9t-20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Dec 2020 13:59:23 -0800 Received: from intmgw001.41.prn1.facebook.com (2620:10d:c085:108::8) by mail.thefacebook.com (2620:10d:c085:11d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 1 Dec 2020 13:59:11 -0800 Received: by devvm3388.prn0.facebook.com (Postfix, from userid 111017) id 718ED19702B4; Tue, 1 Dec 2020 13:59:06 -0800 (PST) From: Roman Gushchin To: CC: , , , , , , , Subject: [PATCH bpf-next v9 11/34] bpf: refine memcg-based memory accounting for devmap maps Date: Tue, 1 Dec 2020 13:58:37 -0800 Message-ID: <20201201215900.3569844-12-guro@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20201201215900.3569844-1-guro@fb.com> References: <20201201215900.3569844-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-01_11:2020-11-30,2020-12-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=855 malwarescore=0 spamscore=0 suspectscore=13 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010131 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include map metadata and the node size (struct bpf_dtab_netdev) into the accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/devmap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index 2b5ca93c17de..b43ab247302d 100644 --- a/kernel/bpf/devmap.c +++ b/kernel/bpf/devmap.c @@ -175,7 +175,7 @@ static struct bpf_map *dev_map_alloc(union bpf_attr *= attr) if (!capable(CAP_NET_ADMIN)) return ERR_PTR(-EPERM); =20 - dtab =3D kzalloc(sizeof(*dtab), GFP_USER); + dtab =3D kzalloc(sizeof(*dtab), GFP_USER | __GFP_ACCOUNT); if (!dtab) return ERR_PTR(-ENOMEM); =20 @@ -602,8 +602,9 @@ static struct bpf_dtab_netdev *__dev_map_alloc_node(s= truct net *net, struct bpf_prog *prog =3D NULL; struct bpf_dtab_netdev *dev; =20 - dev =3D kmalloc_node(sizeof(*dev), GFP_ATOMIC | __GFP_NOWARN, - dtab->map.numa_node); + dev =3D bpf_map_kmalloc_node(&dtab->map, sizeof(*dev), + GFP_ATOMIC | __GFP_NOWARN, + dtab->map.numa_node); if (!dev) return ERR_PTR(-ENOMEM); =20 --=20 2.26.2