Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp392965pxu; Tue, 1 Dec 2020 14:04:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzoxyyI9Zamvb9cPhDgJ44+pV30aMK+/1r7JcLsBdXeqAgUrWcyQuV4QNnyjC9gOnbhyfHZ X-Received: by 2002:aa7:db0c:: with SMTP id t12mr5376380eds.41.1606860298140; Tue, 01 Dec 2020 14:04:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606860298; cv=none; d=google.com; s=arc-20160816; b=uQ+Ea0X/Lw4wogc09oveZ/YiNjvpPAPgJr6Tb/5Ojck5sV6r531YpvHq5QX65/T5mn VstCBSxq62YxCcP4mtpDzx3F9clzCag3xl/gl97USGNpn9mth6xXOdqF+P0v88bXU4Tl 0EKIoxQYUNqG92CvP8zgD71hKL3/fW+cNc8aWCn+fi2FDbb+AnICOaSVBCP1BOyvpXpk yMzsy3dd/d/eNN5gaOAA+61TRIhWJrETZZvXHhYEe5tk0j6UDDyjs8AxLMrkFW2R4VtB vwi3uMWoKjSuG4jAo2D7cumPlv34W9Oh+x1QgUJHD3D6d3ZmqLbbTztRdUBeCpUL4Vk0 iB9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=h6PXB4ExcT3GP3qFAXy2gqJvs6xVABY40pGBrkACiCE=; b=ZSBj97+pN6zj4bpOvI2o71fuoIuGqYb6Lapsw+2jfZJ15u5/4yAvqapzJD7ni/PVd8 3UWP/vZWmIzYDoV/aC/Q/A0A4T9Jq0SCYPQ23/oB6Tr38dk6d+0Q0Tq2hEVp+Ew77s+S OzjESILVeObJYzrAH0e3mRLVAs+zqT0lMs34lkjET2dywlxLb47uBo6rr81UVybVlAYJ EjZ5BiL8qnc4Jw5OtwpBf0P5WyuPDNgWGWITWr+iPOjrAbeEkPvz7Uw1JKT1ZVbLcO7H +aVi9CkDOf/KEVQbYlt/FURocZAU48pRbtAb+WaJPoqJHATzDEwKWPn0xnIHnRx4hJ7b f/Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=FjD3dcqV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si718248edi.388.2020.12.01.14.04.35; Tue, 01 Dec 2020 14:04:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=FjD3dcqV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404205AbgLAWCC (ORCPT + 99 others); Tue, 1 Dec 2020 17:02:02 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:57552 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389788AbgLAV7z (ORCPT ); Tue, 1 Dec 2020 16:59:55 -0500 Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B1LolBo025366 for ; Tue, 1 Dec 2020 13:59:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=h6PXB4ExcT3GP3qFAXy2gqJvs6xVABY40pGBrkACiCE=; b=FjD3dcqVkmhjP4QcEjEpCKOZB9124VJ995HIXfn0j3NgqcFU3fL0NFYK4ufCvFOaOsgI MbZAL/DX9KKu0H2mgkVAXB2CKXB8F7eC+4GvqLiR3l096HELJyuidz0WTBIW0ebQ+NxB 8ntBGgbdsoWDeEjylaxmQljVglW4xdrXLE4= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 3547g8q51m-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Dec 2020 13:59:14 -0800 Received: from intmgw002.41.prn1.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 1 Dec 2020 13:59:10 -0800 Received: by devvm3388.prn0.facebook.com (Postfix, from userid 111017) id CE3FC19702DA; Tue, 1 Dec 2020 13:59:06 -0800 (PST) From: Roman Gushchin To: CC: , , , , , , , Subject: [PATCH bpf-next v9 30/34] bpf: eliminate rlimit-based memory accounting for xskmap maps Date: Tue, 1 Dec 2020 13:58:56 -0800 Message-ID: <20201201215900.3569844-31-guro@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20201201215900.3569844-1-guro@fb.com> References: <20201201215900.3569844-1-guro@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-01_11:2020-11-30,2020-12-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=13 phishscore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=857 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010131 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not use rlimit-based memory accounting for xskmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- net/xdp/xskmap.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c index 9fff1e6dc9cd..113fd9017203 100644 --- a/net/xdp/xskmap.c +++ b/net/xdp/xskmap.c @@ -58,9 +58,8 @@ static void xsk_map_sock_delete(struct xdp_sock *xs, =20 static struct bpf_map *xsk_map_alloc(union bpf_attr *attr) { - struct bpf_map_memory mem; - int err, numa_node; struct xsk_map *m; + int numa_node; u64 size; =20 if (!capable(CAP_NET_ADMIN)) @@ -74,18 +73,11 @@ static struct bpf_map *xsk_map_alloc(union bpf_attr *= attr) numa_node =3D bpf_map_attr_numa_node(attr); size =3D struct_size(m, xsk_map, attr->max_entries); =20 - err =3D bpf_map_charge_init(&mem, size); - if (err < 0) - return ERR_PTR(err); - m =3D bpf_map_area_alloc(size, numa_node); - if (!m) { - bpf_map_charge_finish(&mem); + if (!m) return ERR_PTR(-ENOMEM); - } =20 bpf_map_init_from_attr(&m->map, attr); - bpf_map_charge_move(&m->map.memory, &mem); spin_lock_init(&m->lock); =20 return &m->map; --=20 2.26.2